Ruff rules for comprehensions, performance, and simplicity #23040
Conversation
cclauss
force-pushed
the
ruff-tools-directory
branch
5 times, most recently
from
edff17e to
dd3c9bc
Compare
tools/toolchain_profiler.py
Outdated
| @staticmethod | ||
| def escape_args(args): | ||
| return map(lambda arg: ToolchainProfiler.escape_string(arg), args) | ||
| return (ToolchainProfiler.escape_string(arg) for arg in args) |
There was a problem hiding this comment.
Just return a list here maybe? [ToolchainProfiler.escape_string(arg) for arg in args]
There was a problem hiding this comment.
map() returns an iterator in Python 3 so the linter's fix wants to return a generator expression. Lists take more RAM than maps and generators.
There was a problem hiding this comment.
Sure, this is far from memory critical code though and I think the explicit list is more idiomatic (at least to my old fasioned eyes).
There was a problem hiding this comment.
I will change this but...
The Py 2 to 3 transition contained a few key transitions.
bytes == strvs.bytes != str- https://docs.python.org/3/whatsnew/3.0.html#print-is-a-function (and related changes)
- https://docs.python.org/3/whatsnew/3.0.html#views-and-iterators-instead-of-lists
Lists were more idiomatic in legacy Python but the push towards iterators was quite deliberate.
|
Can you include the command line you used to generate this PR (in the PR description). |
cclauss
force-pushed
the
ruff-tools-directory
branch
2 times, most recently
from
cf2cfe9 to
8c9e584
Compare
cclauss
force-pushed
the
ruff-tools-directory
branch
from
bcef3ea to
b28ffa6
Compare
…n-core#23040) Only in the `tools/` directory apply ruff rules for comprehensions, performance, and simplicity. * https://docs.astral.sh/ruff * https://docs.astral.sh/ruff/rules/#flake8-comprehensions-c4 * https://docs.astral.sh/ruff/rules/#perflint-perf * https://docs.astral.sh/ruff/rules/#flake8-simplify-sim This pull request was roughly created via the command: `ruff --select=C4,PERF,Q,SIM --ignore=SIM108,SIM300 lint.flake8-quotes.inline-quotes=single --fix --unsafe-fixes`
2 participants
Only in the
tools/directory apply ruff rules for comprehensions, performance, and simplicity.This pull request was roughly created via the command:
ruff --select=C4,PERF,Q,SIM --ignore=SIM108,SIM300 lint.flake8-quotes.inline-quotes=single --fix --unsafe-fixes