Refactor startup code to avoid duplication between wasm workers and pthreads. NFC #23110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
simplify_worker_init
branch
from
f762c8b to
1120417
Compare
…threads. NFC Split out from emscripten-core#23106
sbc100
force-pushed
the
simplify_worker_init
branch
from
1120417 to
c9c9d19
Compare
kripken
approved these changes
Dec 9, 2024
| @@ -1 +1 @@ | |||
| 8703 | |||
| 8716 | |||
There was a problem hiding this comment.
Probably noise, but might be worth seeing why this regressed.
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
…threads. NFC (emscripten-core#23110) Split out from emscripten-core#23106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #23106