[test] Remove EMSCRIPTEN_KEEPALIVE from _ReportResult. NFC #23119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the emscripten side we have `reportResultToServer` already.
kripken
approved these changes
Dec 11, 2024
| #ifdef REPORT_RESULT | ||
| __ReportResult(0); | ||
| #endif | ||
| reportResultToServer(0); |
There was a problem hiding this comment.
Will this not report more than before? Or was REPORT_RESULT always defined?
There was a problem hiding this comment.
I don't think anyone is ever going to want to build this test without browser reporting included
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
…n-core#23119) On the emscripten side we have `reportResultToServer` already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the emscripten side we have
reportResultToServeralready.