Skip to content

[test] Remove EMSCRIPTEN_KEEPALIVE from _ReportResult. NFC #23119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[test] Remove EMSCRIPTEN_KEEPALIVE from _ReportResult. NFC #23119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/pthread/call_async_on_main_thread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ addToLibrary({
console.error('This function should be getting called on the main thread!');
}
console.log('got ' + param1 + ' ' + param2 + ' ' + param3);
__ReportResult(param1 + param2 * param3);
reportResultToServer(param1 + param2 * param3);
}
});
4 changes: 2 additions & 2 deletions test/report_result.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ extern "C" {

#if defined __EMSCRIPTEN__ && !defined EMTEST_NODE

void EMSCRIPTEN_KEEPALIVE _ReportResult(int result) {
void _ReportResult(int result) {
EM_ASM(reportResultToServer($0), result);
}

void EMSCRIPTEN_KEEPALIVE _MaybeReportResult(int result) {
void _MaybeReportResult(int result) {
EM_ASM(maybeReportResultToServer($0), result);
}

Expand Down
4 changes: 1 addition & 3 deletions test/webaudio/create_webaudio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ int main()
startButton.onclick = () => {
if (audioContext.state != 'running') {
audioContext.resume();
#ifdef REPORT_RESULT
__ReportResult(0);
#endif
reportResultToServer(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this not report more than before? Or was REPORT_RESULT always defined?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anyone is ever going to want to build this test without browser reporting included

} else {
audioContext.suspend();
}
Expand Down
Loading