Remove the need for runCaller. NFC
#23193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
simplify_dependenciesFulfilled
branch
from
0b12546 to
4cf19a9
Compare
sbc100
force-pushed
the
simplify_dependenciesFulfilled
branch
from
4cf19a9 to
a291a00
Compare
This change removes the need for `runCaller` and the `calledRun` global. Instead we simply set `dependenciesFulfilled` to `run` directly each time to return early due to outstanding dependencies. This also means that we don't need a reentrancy check on `doRun` since `dependenciesFulfilled` is only set in the case where `doRun` didn't actually run. This both simplifies the code and saves on code size.
sbc100
force-pushed
the
simplify_dependenciesFulfilled
branch
from
a291a00 to
5fd2a66
Compare
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
This change removes the need for `runCaller` and the `calledRun` global. Instead we simply set `dependenciesFulfilled` to `run` directly each time to return early due to outstanding dependencies. This also means that we don't need a reentrancy check on `doRun` since `dependenciesFulfilled` is only set in the case where `doRun` didn't actually run. This both simplifies the code and saves on code size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the need for
runCallerand thecalledRunglobal. Instead we simply setdependenciesFulfilledtorundirectly each time to return early due to outstanding dependencies.This also means that we don't need a reentrancy check on
doRunsincedependenciesFulfilledis only set in the case wheredoRundidn't actually run.This both simplifies the code and saves on code size.