Skip to content

Fix wasm table access when accessing functions in splitted module #25432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −3
Open

Fix wasm table access when accessing functions in splitted module #25432

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a1d39e
Fix wasm table access
Mintyboi Sep 30, 2025
5269096
Combine logic to have a single return statement
Mintyboi Sep 30, 2025
a01c931
Add missing semi colon
Mintyboi Sep 30, 2025
680fdf6
Merge branch 'main' into fix-split-module-load
Mintyboi Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/preamble.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,10 +503,9 @@ var splitModuleProxyHandler = {
// When the table is dynamically laid out, the placeholder functions names
// are offsets from the table base. In the main module, the table base is
// always 1.
return wasmTable.get(1 + parseInt(prop))(...args);
#else
return wasmTable.get(prop)(...args);
prop = 1 + parseInt(prop)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a semicolon at end of line.

#endif
return wasmTable.get({{{ toIndexType('prop') }}})(...args);
#endif
}
}
Expand Down