Remove windows-specific console coloring #25502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
ansi_color
branch
2 times, most recently
from
4fbd4f9 to
8e08d2c
Compare
sbc100
force-pushed
the
ansi_color
branch
3 times, most recently
from
8d5ff02 to
8fdc8e3
Compare
|
I merged this branch against my PR branch #25495 and verified that this will not disrupt the coloring added in that branch on Windows 10. LGTM. |
juj
approved these changes
Oct 6, 2025
Windows 10 and above support ANSI coloring and there should be very few emscripten users on older version of windows at this point (if any?). The downside is that windows 7 will no longer have nice colored error messages, but the upside is that we can cleanup and refactor this code now (see emscripten-core#25495).
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 6, 2025
Now the ANSI colors are always used we can make this function much simpler. Followup to emscripten-core#25502.
This was referenced Oct 6, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 6, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 6, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows 10 and above support ANSI coloring and there should be very few emscripten users on older version of windows at this point (if any?).
emscripten already does not support windows 7 IIUC, since its dependencies (both python 3 and node 18) do not support windows 7
This means that only windows 8 users should be effected by this change. The upside is that we can cleanup and refactor this code now (see #25495).