deps: yaml-cpp: Updating to latest main version

[adisuissa]

Commit Message: deps: yaml-cpp: Updating to latest main version
Additional Description:
Risk Level: Low.
Testing: N/A.
Docs Changes: N/A.
Release Notes: N/A.
Platform Specific Features: N/A.
Fixes #20762

Signed-off-by: Adi Suissa-Peleg [email protected]

[repokitteh-read-only]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #20765 was opened by adisuissa.

see: more, trace.

[moderation]

Windows CI error looks real

/lgtm deps

[phlax]

they dont seem obviously related - other than yaml issues - but there is a failing windows test on the latest dependabot pr to update jinja2 here https://dev.azure.com/cncf/envoy/_build/results?buildId=104760&view=logs&j=4afecb4c-71c7-5b5c-ab99-a70ed4c927ad&t=4cd2fc51-3314-5d69-4df3-f765ae0c08dc&l=1698

[adisuissa]

The related failures seem to be due to changes by this PR jbeder/yaml-cpp#1045
That PR was previously reverted, and this introduced a similar fix.
It seems that there was a further issue with PR 1045, described here: jbeder/yaml-cpp#1063
This was later fixed in jbeder/yaml-cpp#1064.

I'll keep digging.

[adisuissa]

/wait

[adisuissa]

Any chance of having this change made upstream so we don't have to carry a patch? And please add a TODO(adisuissa): ... on what needs to happen to remove the patch.

/cc @envoyproxy/dependency-shepherds

Yes.
Unfortunately I don't have access to a windows build machine, so using CI for building/testing.
Once we have a good version, I'll send the patch to the yaml-cpp repo.

[moderation]

Related: #20805

[jmarantz]

Adi do you want to merge main to see if that solves the CI issue?

/wait

[adisuissa]

This is also being worked on in: #20805
The issue is a broken build of the windows yaml-cpp with Bazel. Still working on reproducing this using a windows VM.

[vehre-x41]

#20805 is now superceeded by #20886 ,which merges main but also had to fix yaml_cpp again. I will try to get the required fixes into yaml_cpp once the build is passing and really everything is fixed...

[adisuissa]

Closing in favor of: #20886