Skip to content

WIP deps: Update yaml_cpp #20805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vehre-x41 wants to merge 74 commits into from
Closed

WIP deps: Update yaml_cpp #20805

vehre-x41 wants to merge 74 commits into from

Conversation

@vehre-x41
Copy link
Contributor

@vehre-x41 vehre-x41 commented Apr 13, 2022

Commit Message: deps: Update yaml_cpp
Additional Description:
Signed-off-by: Andre Vehreschild vehre@x41-dsec.de
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: windows

@vehre-x41
deps: Update yaml_cpp
a8115bb 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Apr 13, 2022
@repokitteh-read-only
Copy link

repokitteh-read-only bot commented Apr 13, 2022

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @wrowe

🐱

Caused by: #20805 was opened by vehre-x41.

see: more, trace.

@vehre-x41 vehre-x41 marked this pull request as draft April 13, 2022 08:39
@vehre-x41
fix typo
735ee77 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
define correct symbol
b727ed2 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
next try
d1aed5e 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
use local_defines
c1c8893 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
dll export constructor explicitly.
e476caa 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
ignore linker warning
058a082 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
use the correct linker warning to ignore.
b776c73 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
add linker flags to linkopts instead of copts
db7b8fa 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@moderation moderation mentioned this pull request Apr 13, 2022
Closed
@moderation
Copy link
Contributor

moderation commented Apr 13, 2022

Related: #20765. As per #20765 (comment) it would be good to fix this upstream so we don't need to carry a patch

@vehre-x41
Unset yaml_cpp_EXPORTS where the library is used.
7cfc502 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
fix formatting
fc963bc 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
yaml_cpp: use static linking for windows.
140e300 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
fix empty defines.
a1a286e 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
Copy link
Contributor Author

vehre-x41 commented Apr 14, 2022

@adisuissa, the compile works now, but tests are failing. I am not sure, what has caused this. I'll look into that on Tuesday.

@adisuissa
Copy link
Contributor

adisuissa commented Apr 14, 2022

@adisuissa, the compile works now, but tests are failing. I am not sure, what has caused this. I'll look into that on Tuesday.

Thanks for working on this!
I'm not sure if this patch is going to be accepted in yaml-cpp, as it uses static linking when Bazel is used (but not when CMake is used).

The new test failure is strange:

2022-04-14T15:43:00.5557795Z [ RUN      ] ValidConfigs/ValidationServerTest.Validate/0
2022-04-14T15:43:00.5558694Z [2022-04-14 15:42:53.659][2328][critical][main] [source/server/config_validation/server.cc:63] error initializing configuration 'C:/botcode/w38/_tmp/a1352f7d3a1bf832d65df2942ea639ef/test/config_test/front-proxy_front-envoy.yaml': yaml-cpp: error at line 81, column 19: end of map not found
2022-04-14T15:43:00.5559399Z 
2022-04-14T15:43:00.5560113Z test/server/config_validation/server_test.cc(89): error: Value of: validateConfig(options_, Network::Address::InstanceConstSharedPtr(), component_factory_, Thread::threadFactoryForTest(), Filesystem::fileSystemForTest())
2022-04-14T15:43:00.5560874Z   Actual: false
2022-04-14T15:43:00.5561302Z Expected: true
2022-04-14T15:43:00.5561620Z Stack trace:
2022-04-14T15:43:00.5561966Z   00007FF7EDFC4446: (unknown)
2022-04-14T15:43:00.5562342Z   00007FF7EDFDD5F8: (unknown)
2022-04-14T15:43:00.5563610Z   00007FF7EDFDD7BD: (unknown)
2022-04-14T15:43:00.5564411Z   00007FF7EDFDE22D: (unknown)
2022-04-14T15:43:00.5564830Z ... Google Test internal frames ...
2022-04-14T15:43:00.5565009Z 
2022-04-14T15:43:00.5565502Z [  FAILED  ] ValidConfigs/ValidationServerTest.Validate/0, where GetParam() = "front-proxy_front-envoy.yaml" (8 ms)

(see yaml file: https://github.com/envoyproxy/envoy/blob/main/examples/front-proxy/front-envoy.yaml)

I don't understand why the failure occurs only in windows and not in Linux. Initial hunch is that this is due to some recent change in yaml-cpp.

rainingmaster and others added 9 commits April 19, 2022 09:11
@rainingmaster @vehre-x41
compression: add zstd compressor and decompressor (envoyproxy#20434)
9d82cbc 
Signed-off-by: rainingmaster <jinhua.tan@bytedance.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@phlax @vehre-x41
ci: Pin macos-latest VM version (envoyproxy#20758)
f427582 
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@phlax @vehre-x41
build: Pin distroless base image with sha (envoyproxy#20759)
66a2f70 
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@danzh2010 @vehre-x41
conn_pool_grid: try TCP immediately with h3 state FailedRecently (env…
03b0a11 
…oyproxy#20722)

Commit Message: Add a new state FailedRecently to the status tracker. And make the connectivity grid check this state in newStream(). If the h3 pool is in this state, do not delay TCP racing.

Risk Level: low, grid only
Testing: added unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Part of envoyproxy#18715

Signed-off-by: Dan Zhang danzh@google.com
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@JuniorHsu @vehre-x41
thrift: Explicitly express no cluster header for weighted clusters (e…
c96b6dc 
…nvoyproxy#20679)

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>

Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@keith @vehre-x41
bazel: Update to 5.1.1
80635c9 
We tried updating to 5.1.0 which fixed some remote cache issues, but
that had a regression where all action failures would appear to be
remote cache flakes instead, this was fixed in 5.1.1

https://github.com/bazelbuild/bazel/releases/tag/5.1.1

Fixes: envoyproxy#20599

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@durd07 @vehre-x41
contrib-sipproxy: Fix the coredump when teardown (envoyproxy#20580)
16ec0bb 
When their are more than one TRA subscribe actions, stream_ maybe
overwrited which cause the last connection can't be resetted gracefully.
so introduce a list of stream_callbacks and request_callbacks.

Signed-off-by: Felix Du <durd07@gmail.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@jacob-delgado @vehre-x41
http_connection_manager: support multiple SAN URIs for XFCC (envoypro…
1a21b50 
…xy#20724)

...when using APPEND_FORWARD and SANITIZE set.

Currently XFCC only keeps the first URI in a certificate or a header presented
to it.

This works fine for most use cases, however, not everyone uses a single
URI (typically spiffe:// only).

Add every URI present to the 'By=' portion as well as the 'URI=' portion of an
XFCC header.

Additional Description:
Risk Level: Low
Testing: Unit and integration tests
Docs Changes: Yes. The appropriate http_connection_managers configuration section.
Release Notes: Yes
Fixes envoyproxy#20723

Signed-off-by: Jacob Delgado <jacob.delgado@volunteers.acasi.info>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@RyanTheOptimist @vehre-x41
Update QUICHE from bac04054b to 8864d08f6 (envoyproxy#20747)
97fd499 
Update QUICHE from bac04054b to 8864d08f6
https://github.com/google/quiche/compare/bac04054b..8864d08f6

$ git log bac04054b..8864d08f6 --date=short --no-merges --format="%ad %al %s"

2022-04-11 diannahu Fix the receipt of GOAWAYs as the server in oghttp2.
2022-04-11 danzh Automated g4 rollback of changelist 437128224.
2022-04-11 bnc Platformize enforcing header policy in Balsa.
2022-04-11 vasilvv Use relative include paths for OpenSSL and zlib in QUICHE.
2022-04-11 diannahu Handle new/pending streams on receipt of a GOAWAY in oghttp2.
2022-04-11 bnc Fix header guards in QUICHE.
2022-04-11 wub Deprecate --gfe2_reloadable_flag_quic_tls_no_select_cert_if_disconnected.
2022-04-11 fayang Internal change
2022-04-08 rch Make QUICHE pragmas which disable warnings google3-specific.
2022-04-08 haoyuewang Remove connection_option RVCM such that IETF QUIC connection migration is default on.
2022-04-08 wub Change QuicPathChallengeFrame and QuicPathResponseFrame to be inlined quic frame.
2022-04-07 diannahu Update oghttp2 to close streams above a received GOAWAY's last_stream_id.
2022-04-07 renjietang Change default path degrading delay to 4PTOs when PTO is enabled.
2022-04-07 martinduke Minor cleanup of the QUIC-LB library. Take review comments from late in the process and apply them to earlier classes.
2022-04-07 quiche-dev Internal change

Signed-off-by: Ryan Hamilton rch@google.com
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
tyxia and others added 23 commits April 19, 2022 09:11
@tyxia @vehre-x41
GCP Authentication Filter: Implement response path (envoyproxy#20819)
44474a4 
* GCP Authentication Filter: Implement response path

Signed-off-by: Tianyu Xia <tyxia@google.com>

Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@jmarantz @vehre-x41
admin: roll back stats_handler.cc et al back to previous state while …
465678b 
…we sort out some sporadic crashes (envoyproxy#20835)

Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@keith @vehre-x41
bazel: add temporary rules_rust patch
73bdee8 
This enables building rust that targets android devices until the
upstream PR is released. It shouldn't affect any other configuration
since it's scoped to the triple.

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@keith @vehre-x41
bazel: add mobile rust toolchains
1769933 
This is preliminary work for getting rust working in envoy mobile. This
should be minimal overhead in the case you're not actually building rust
for mobile. If it becomes an issue we can inject this from the consumers
of `envoy_dependency_imports`.

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@soulxu @vehre-x41
doc: add note for original source listener filter required CAP_NET_AD…
f247418 
…MIN (envoyproxy#20846)

Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@RyanTheOptimist @vehre-x41
docs: Add an overview of Happy Eyeballs Support (envoyproxy#20621)
f4f5f77 
Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@PiotrSikora @vehre-x41
wasm: update Proxy-Wasm Rust SDK to v0.2.0. (envoyproxy#20743)
d1b9d12 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@soulxu @vehre-x41
listener: closes filter chain draining listener's sockets when the re…
5a8cab0 
…lated active listener removed (envoyproxy#20702)

Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@mattklein123 @vehre-x41
release: 1.22 (envoyproxy#20847)
77787d3 
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@mattklein123 @vehre-x41
release: kick off 1.23 (envoyproxy#20849)
fa11a2c 
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@lambdai @vehre-x41
test: allow dispatcher test cases running on ipv6 only env (envoyprox…
4dfea4f 
…y#20854)

Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@dependabot @vehre-x41
build(deps): bump actions/checkout from 3.0.0 to 3.0.1 (envoyproxy#20848
88ce393 
)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@a12a394...dcd71f6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
tls: remove SHA-1 cipher suites from the defaults on the server-side (e…
368cdec 
…nvoyproxy#20643)

Signed-off-by: derekguo001 <dong.guo@intel.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@yanavlasov @vehre-x41
Add bazel option for enabling Universal Header Validator (envoyproxy#…
f0ceff0 
…20845)

Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@phlax @vehre-x41
dist: Add debian packaging (envoyproxy#17979)
042f0f7 
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@dependabot @vehre-x41
build(deps): bump actions/setup-python from 3.1.0 to 3.1.2 (envoyprox…
863245f 
…y#20770)

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 3.1.0 to 3.1.2.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@9c644ca...98f2ad0)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@dependabot @vehre-x41
build(deps): bump setuptools from 62.0.0 to 62.1.0 in /tools/base (en…
62998a6 
…voyproxy#20771)

Bumps [setuptools](https://github.com/pypa/setuptools) from 62.0.0 to 62.1.0.
- [Release notes](https://github.com/pypa/setuptools/releases)
- [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst)
- [Commits](pypa/setuptools@v62.0.0...v62.1.0)

---
updated-dependencies:
- dependency-name: setuptools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@dependabot @vehre-x41
build(deps): bump pyparsing from 3.0.7 to 3.0.8 in /tools/dependency (e…
6ce635d 
…nvoyproxy#20769)

Bumps [pyparsing](https://github.com/pyparsing/pyparsing) from 3.0.7 to 3.0.8.
- [Release notes](https://github.com/pyparsing/pyparsing/releases)
- [Changelog](https://github.com/pyparsing/pyparsing/blob/master/CHANGES)
- [Commits](pyparsing/pyparsing@pyparsing_3.0.7...pyparsing_3.0.8)

---
updated-dependencies:
- dependency-name: pyparsing
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@keith @vehre-x41
bazel: move shared action_env above enable_platform_specific_config
aa65d6c 
This fixes an issue where the PATH wasn't actually set to what we tried
to force as the default on macOS. I'm not sure if this is a bazel bug or
not, but either way it's surprising behavior.

bazelbuild/bazel#15270

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>

Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
docs: fix doc link for composite filter (envoyproxy#20865)
04971a6 
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@soulxu @vehre-x41
listener: remove the peek from the listener filters (envoyproxy#20728)
f6c60e8 
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@kyessenov @vehre-x41
matchers: extend network inputs to HTTP requests (envoyproxy#20796)
0cfed4c 
Extend network inputs (e.g. source IP) to HTTP requests. Reuse all code with templates.

Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@mpwarres @vehre-x41
ext_proc: Support per-route GrpcService configuration. (envoyproxy#20757
49dec6d 
)

This adds the ability to change the GrpcService used by the ext_proc filter on a per-route basis.

Risk Level: Low. Not triggered unless configured.
Testing: New unit and integration tests added.
Docs Changes: Addition of new config field.

Signed-off-by: Michael Warres <mpw@google.com>
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@repokitteh-read-only
Copy link

repokitteh-read-only bot commented Apr 19, 2022

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #20805 was synchronize by vehre-x41.

see: more, trace.

@vehre-x41
Copy link
Contributor Author

vehre-x41 commented Apr 19, 2022

Just checking, if test issues reported by the previous build are already fixed upstream. Sorry, for the big merge.

@vehre-x41
WIP: Patch yaml_cpp for testing only.
b8e939b 
Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
@vehre-x41
Copy link
Contributor Author

vehre-x41 commented Apr 19, 2022

Superceeded by PR 20886 now.

@vehre-x41 vehre-x41 closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zuercher zuercher Awaiting requested review from zuercher zuercher will be requested when the pull request is marked ready for review zuercher is a code owner

@kyessenov kyessenov Awaiting requested review from kyessenov kyessenov will be requested when the pull request is marked ready for review kyessenov is a code owner

@nezdolik nezdolik Awaiting requested review from nezdolik nezdolik will be requested when the pull request is marked ready for review nezdolik is a code owner

@ggreenway ggreenway Awaiting requested review from ggreenway ggreenway will be requested when the pull request is marked ready for review ggreenway is a code owner

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 will be requested when the pull request is marked ready for review mattklein123 is a code owner

@wbpcode wbpcode Awaiting requested review from wbpcode wbpcode will be requested when the pull request is marked ready for review wbpcode is a code owner

@KBaichoo KBaichoo Awaiting requested review from KBaichoo KBaichoo will be requested when the pull request is marked ready for review KBaichoo is a code owner

@tyxia tyxia Awaiting requested review from tyxia tyxia will be requested when the pull request is marked ready for review tyxia is a code owner

@yanavlasov yanavlasov Awaiting requested review from yanavlasov yanavlasov will be requested when the pull request is marked ready for review yanavlasov is a code owner

@abeyad abeyad Awaiting requested review from abeyad abeyad will be requested when the pull request is marked ready for review abeyad is a code owner

@RyanTheOptimist RyanTheOptimist Awaiting requested review from RyanTheOptimist RyanTheOptimist will be requested when the pull request is marked ready for review RyanTheOptimist is a code owner

@botengyao botengyao Awaiting requested review from botengyao botengyao will be requested when the pull request is marked ready for review botengyao is a code owner

@agrawroh agrawroh Awaiting requested review from agrawroh agrawroh will be requested when the pull request is marked ready for review agrawroh is a code owner

@phlax phlax Awaiting requested review from phlax phlax will be requested when the pull request is marked ready for review phlax is a code owner

Assignees

@wrowe wrowe

@markdroth markdroth

Labels

api deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.