Skip to content

protodoc: Fix aspect and speedup api/rst build#21576

Merged
htuch merged 1 commit intoenvoyproxy:mainfrom
phlax:protodoc-one-time
Jun 15, 2022
Merged

protodoc: Fix aspect and speedup api/rst build#21576
htuch merged 1 commit intoenvoyproxy:mainfrom
phlax:protodoc-one-time

Conversation

@phlax
Copy link
Member

@phlax phlax commented Jun 4, 2022

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax force-pushed the protodoc-one-time branch from 5448cfd to 1a2dada Compare June 4, 2022 10:28
@phlax
Copy link
Member Author

phlax commented Jun 4, 2022

/docs

@repokitteh-read-only
Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/21576/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #21576 (comment) was created by @phlax.

see: more, trace.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the protodoc-one-time branch from 1a2dada to fcb2a51 Compare June 4, 2022 10:57
@phlax
Copy link
Member Author

phlax commented Jun 6, 2022

closing this in favour of #21579

@phlax phlax closed this Jun 6, 2022
@phlax phlax reopened this Jun 12, 2022
@phlax
Copy link
Member Author

phlax commented Jun 12, 2022

given that we are keeping aspects, i think this change is desirable

@phlax
Copy link
Member Author

phlax commented Jun 14, 2022

cc @htuch i think it would be good to get this one out of the way - its a pretty straight fix to expectation

@RyanTheOptimist
Copy link
Contributor

/assign @htuch

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit cff92a6 into envoyproxy:main Jun 15, 2022
Amila-Rukshan pushed a commit to Amila-Rukshan/envoy that referenced this pull request Jun 28, 2022
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Amila Senadheera <amila.15@cse.mrt.ac.lk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants