Add paragraph on re-requesting reviews in code reviews#146
Merged
Conversation
✅ Deploy Preview for playful-gelato-7892ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bisaloo
approved these changes
Feb 11, 2025
chartgerink
approved these changes
Feb 12, 2025
Member
Author
|
Thanks for the approval. I'll let the code owner/maintainer merge the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a paragraph to the
code-review.qmdpage of the blueprints, providing guidelines on how to proceed with pull requests after a reviewer has requested changes.It does not strictly require a specific workflow, but rather provides Epiverse-TRACE with guidelines to maximise communication between reviewer and reviewee to ensure code quality is optimised through pull request review process.
This was worked on collaboratively with @jamesmbaazam, and was discussed in the Epiverse-TRACE development meeting (2025-02-11) to ensure a rough consensus on the guidelines is agreed.