General cleanup: remove unused signals and dead code

[ericlewis]

• Remove 17 unused signals from llander_top.vhd (vestigial RAM signals
  from Asteroids Deluxe base that were never connected)
• Remove 10 unused signals from llander.vhd (unimplemented sound
  placeholders and unused declarations)
• Remove dead noiserst_l assignment (signal was assigned but never read)
• Fix missing clk_6k assignment in clock divider (was declared and read
  but never driven, causing tone6khz to always be zero)
• Remove commented-out old ROM instantiation code from llander.vhd
  and llander_vg.vhd
• Clean up formatting: consistent 2-space indentation, aligned port
  maps, removed excessive blank lines in llander_top.vhd
• Mark 'General cleanup' TODO item as done

https://claude.ai/code/session_01QmPirfEXJ1bsJHb9i98uGS

---

Note

Medium Risk
Mostly build/packaging and cleanup, but it also changes synthesizable clock/audio behavior (clk_6k) and adds automated versioning/releases, which could affect outputs if misconfigured.

Overview
Adds a new GitHub Actions workflow (.github/workflows/build.yml) that compiles the Quartus project, bit-reverses the generated .rbf, auto-increments a v* tag-based version, stamps core.json, packages dist/ assets into a release/ artifact, and (on main pushes) creates a zip and GitHub Release.

Cleans up the VHDL sources by removing unused/vestigial signals and commented-out ROM blocks, standardizing dpram instantiations to entity work.dpram, and fixing the clock divider in llander.vhd by actually driving clk_6k (restoring the 6kHz tone path). Also updates src/fpga/.gitignore to ignore *.cf.

^{Written by Cursor Bugbot for commit 2a3b53f. This will update automatically on new commits. Configure here.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: edc9c4a0aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Unindent inline Python passed to python3 -c

The "Reverse bitstream" step sends a multi-line script to python3 -c, but each statement is indented (with open(...) starts with leading spaces), which Python treats as top-level unexpected indentation and raises IndentationError before any packaging occurs. This makes the workflow fail consistently on GitHub Actions runners; use unindented code (or a here-doc) for the inline script.

Useful? React with 👍 / 👎.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[cursor]

Version computation lacks semver validation

Medium Severity

The version computation extracts version components using cut without validating the tag format. If a git tag doesn't follow strict semver format (e.g., v1.0 instead of v1.0.0, or v1.0.0-beta), the PATCH variable could be empty or contain non-numeric characters, causing PATCH=$((PATCH + 1)) to either silently produce incorrect versions or fail with a bash arithmetic error, breaking the CI build and release process.