generated from open-fpga/core-template
-
Notifications
You must be signed in to change notification settings - Fork 0
General cleanup: remove unused signals and dead code #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1e3dfc2
General cleanup: remove unused signals and dead code
claude c7aae8a
Fix non-standard VHDL entity instantiation syntax
claude 58a25f5
Add *.cf to .gitignore for GHDL build artifacts
claude edc9c4a
Add GitHub Actions workflow for Quartus synthesis
claude b374639
Trigger CI on claude/** branches for testing
claude 9d0adfe
Fix reverse bitstream step: use heredoc to avoid indentation error
claude 2a3b53f
Add auto-versioned GitHub Releases on merge to main
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| name: Build Core | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| branches: [main] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Compile with Quartus | ||
| uses: raetro/quartus-flow@v1 | ||
| with: | ||
| project: ap_core | ||
| version: pocket | ||
| project_folder: src/fpga | ||
|
|
||
| - name: Reverse bitstream | ||
| run: | | ||
| python3 -c " | ||
| with open('src/fpga/output_files/ap_core.rbf', 'rb') as f: | ||
| data = f.read() | ||
| reversed = bytes(int('{:08b}'.format(b)[::-1], 2) for b in data) | ||
| with open('src/fpga/output_files/bitstream.rbf_r', 'wb') as f: | ||
| f.write(reversed) | ||
| " | ||
|
|
||
| - name: Package core | ||
| run: | | ||
| mkdir -p release/Cores/ericlewis.LunarLander | ||
| cp src/fpga/output_files/bitstream.rbf_r release/Cores/ericlewis.LunarLander/ | ||
| cp -r dist/Cores/ericlewis.LunarLander/*.json release/Cores/ericlewis.LunarLander/ | ||
| cp dist/Cores/ericlewis.LunarLander/icon.bin release/Cores/ericlewis.LunarLander/ | ||
| cp dist/Cores/ericlewis.LunarLander/info.txt release/Cores/ericlewis.LunarLander/ | ||
| cp -r dist/Assets release/ | ||
| cp -r dist/Platforms release/ | ||
|
|
||
| - name: Upload artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: LunarLander-core | ||
| path: release/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,4 +25,5 @@ cr_ie_info.json | |
| *.xml | ||
| *.sld | ||
| *.cdf | ||
| *.cf | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python3 -cThe "Reverse bitstream" step sends a multi-line script to
python3 -c, but each statement is indented (with open(...)starts with leading spaces), which Python treats as top-level unexpected indentation and raisesIndentationErrorbefore any packaging occurs. This makes the workflow fail consistently on GitHub Actions runners; use unindented code (or a here-doc) for the inline script.Useful? React with 👍 / 👎.