You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speedcontrol does not modify the currently active run when overriding the schedule with an import.
The esa-layouts package should adhere to this philosophy so that categories do not get set back to what is on the schedule after an incentivised upgrade for example.
My main issue with your current solution is it will also not modify the run stored in the runDataArray replicant in speedcontrol. IIRC that's what should happen if we want to keep to the same philosophy. Right now there's no easy way of doing this beyond modifying the replicants directly ourselves, so I'd need to add something to speedcontrol directly.
My main issue with your current solution is it will also not modify the run stored in the runDataArray replicant in speedcontrol. IIRC that's what should happen if we want to keep to the same philosophy. Right now there's no easy way of doing this beyond modifying the replicants directly ourselves, so I'd need to add something to speedcontrol directly.
Then it seems like this bug needs to be fixed in speedcontrol
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speedcontrol does not modify the currently active run when overriding the schedule with an import.
The esa-layouts package should adhere to this philosophy so that categories do not get set back to what is on the schedule after an incentivised upgrade for example.