Skip to content

fix: Don't modify the currently active run when (re-)importing schedules #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
duncte123 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Don't modify the currently active run when (re-)importing schedules #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aec4ad8
fix: Don't modify the currently active run when (re-)importing schedules
duncte123 Mar 26, 2023
3fef0ee
Reset shared folder?
duncte123 Mar 26, 2023
d7bbfe7
Merge branch 'esamarathon:master' into fix/current-run-no-modify
duncte123 Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/extension/misc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,13 @@ if (config.tracker.donationTotalInTitle) {
async function formatScheduleImportedPronouns(): Promise<void> {
nodecg().log.info('[Misc] Schedule reimported, formatting pronouns');
const runs = sc.getRunDataArray();
const currentRunId = sc.getCurrentRun()?.id;
for (const run of runs) {
// Do not modify the active run.
if (run.id === currentRunId) {
// eslint-disable-next-line no-continue
continue;
}
const { teams } = run;
teams.forEach((team, x) => {
team.players.forEach((player, y) => {
Expand Down
6 changes: 6 additions & 0 deletions src/extension/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,13 @@ export async function lookupUsersByStr(str: string): Promise<any[]> {
async function lookupScheduleUserInfo(): Promise<void> {
nodecg().log.info('[Server] Schedule reimported, looking up user information');
const runs = sc.getRunDataArray();
const currentRunId = sc.getCurrentRun()?.id;
for (const run of runs) {
// Do not modify the active run.
if (run.id === currentRunId) {
// eslint-disable-next-line no-continue
continue;
}
const userIds = run.customData.userIds ? run.customData.userIds.split(',') : [];
const userDataArr: any[] = [];
for (const id of userIds) {
Expand Down