Experimental: use cargo-batch to reduce CI build times
#244
+658
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comments
|
It's either me dancing the https://github.com/playfulFence/esp-generate/actions/runs/18558236275 |
MabezDev
reviewed
Oct 16, 2025
bugadani
reviewed
Oct 16, 2025
Comment on lines
+78
to
+80
| if ! command -v cargo-batch &> /dev/null; then | ||
| cargo install --git https://github.com/embassy-rs/cargo-batch cargo --bin cargo-batch --locked --force | ||
| fi |
There was a problem hiding this comment.
We shouldn't do this on the normal runners, the xtask should detect if cargo-batch is present and fall back to individual cargo commands otherwise, just like we do for esp-hal. forcing cargo-batch is not the best idea (what if you simply don't want it on your PC, or what if your antivirus decides to remove it suddenly?), we have the code to somewhat smartly generate the commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #242
We probably want to use
m1runner for this to actually have any impact (?)