Skip to content

change: remove STUB_LOG_ENABLE macro from the library usage#4

Merged
erhankur merged 1 commit intoespressif:masterfrom
erhankur:fix/log_macro_usage
Apr 14, 2025
Merged

change: remove STUB_LOG_ENABLE macro from the library usage#4
erhankur merged 1 commit intoespressif:masterfrom
erhankur:fix/log_macro_usage

Conversation

@erhankur
Copy link
Collaborator

Description

  1. The STUB_LOG_ENABLE macro will be enabled from the application and will not be used in the library. Unused functions will not be included in the final binary, so this is okay.
  2. stub_lib_log_printf is implemented in a simple way to avoid using ets_vprintf, which is not defined in the ROM on many targets. Instead of re-implementing it, a simpler approach was chosen.
  3. esp_rom_caps.h files are added for the future use.
  4. Library cmake target names can be configured from the application. This is required by the OpenOCD stub when compiling command-based targets. This approach will also help to pass different compile definitions for each command.

@github-actions
Copy link

github-actions bot commented Apr 11, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello erhankur, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 7b03ba7

@erhankur erhankur requested a review from antmak April 11, 2025 21:33
@erhankur erhankur force-pushed the fix/log_macro_usage branch from c0e35d4 to 7b03ba7 Compare April 12, 2025 10:04
Copy link
Collaborator

@antmak antmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erhankur erhankur merged commit b983e0c into espressif:master Apr 14, 2025
13 checks passed
@erhankur
Copy link
Collaborator Author

@antmak Thanks for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants