-
Notifications
You must be signed in to change notification settings - Fork 41
Improving contributing guide #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
preview available: https://docs.tds.cscs.ch/194 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
preview available: https://docs.tds.cscs.ch/194 |
This comment has been minimized.
This comment has been minimized.
It's confusing to say documentation is owned by everyone and then ask to discuss changes with owners.
d094c10 to
82b76b6
Compare
This comment has been minimized.
This comment has been minimized.
|
preview available: https://docs.tds.cscs.ch/194 |
This comment has been minimized.
This comment has been minimized.
|
Thanks @taliaga! I'll refer you to this comment for now about the spell checker: #177 (comment). Edit: buttons are hard. Fixed the link. |
msimberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few non-blocking comments. This looks like a nice addition to me. Thanks @taliaga!
|
|
||
| !!! tip | ||
| Do you need a screenshot, or can a text description also work? | ||
| #### Screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think screenshot could be added to .github/actions/spelling/allow.txt. Wikipedia seems to use "screenshot" as well (not "screen shot"), so the spell checker is wrong here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding codeowners and screenshots. I wonder which tool/config are you using to keep the alphabetical order? my sort yields something different so I just placed them manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, fair question. Emacs' sort-lines 🙃 I suppose mine sorts caps before lower case, whereas yours maybe mixes them?
Co-authored-by: Mikael Simberg <[email protected]> Co-authored-by: Ben Cumming <[email protected]>
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
preview available: https://docs.tds.cscs.ch/194 |
|
preview available: https://docs.tds.cscs.ch/194 |
|
Thanks reviewers |
Updating contributing guide:
Fun facts worth noting: