-
Notifications
You must be signed in to change notification settings - Fork 41
Improving contributing guide #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
476421a
getting started: propose review before push
taliaga 9a4106e
Clarify Review process
taliaga 6df3f9d
promote diagrams as code
taliaga e8ad955
fix for sentence case
taliaga 82b76b6
fix typos
taliaga 0d88118
Apply suggestions from code review
taliaga b83e6d6
add allowed words for spelling
taliaga dfd16e2
Apply code review suggestions
taliaga c2862f1
Bonus fixes in contributing guide
taliaga 8845159
Merge branch 'main' into upd-contributing
taliaga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -256,6 +256,7 @@ santis | |
| sbatch | ||
| scalapack | ||
| screenshot | ||
| screenshots | ||
| slepc | ||
| slurm | ||
| smartphone | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
screenshotcould be added to.github/actions/spelling/allow.txt. Wikipedia seems to use "screenshot" as well (not "screen shot"), so the spell checker is wrong here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding
codeownersandscreenshots. I wonder which tool/config are you using to keep the alphabetical order? my sort yields something different so I just placed them manuallyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, fair question. Emacs'
sort-lines🙃 I suppose mine sorts caps before lower case, whereas yours maybe mixes them?