Merged
Conversation
WilsontheWolf
approved these changes
Jan 20, 2026
Collaborator
|
{{lovely_hack:patch_dir}} is not replaced with a binary built from this branch |
Rewrite patch loader to support zip mods. Sources are preloaded, replacing fs reads at patch time. Split patch_table.rs into loader.rs and table.rs.
ethangreen-dev
force-pushed
the
zip-loading
branch
from
77f78f9 to
b6d644e
Compare
Our addition of zip loader removed the code that interpolated in the
{{lovely_hack:path_dir}}. This reintroduces it and adds explicit support
for the zip mode by interpolating in the path of the zip instead of a
dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for loading mods from zip archives in the mod directory. Largely a simple implementation but it necessitated changing patch loading to greedily read externally referenced files at load-time instead of patch-time (copy patches, for example).
I also took the opportunity to add some tests and do reorganize a bit. The prior patch-related modules were becoming extremely bloated so I moved them into the patch module.