Skip to content

Add support for zip mods #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethangreen-dev merged 7 commits into from
Jan 21, 2026
Merged

Add support for zip mods #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
96a3cf8
refactor: extract PatchTable to patch_table.rs module
ethangreen-dev Nov 5, 2025
fd45d88
feat: add zip support with source preloading
ethangreen-dev Nov 27, 2025
dad4485
feat: add patch load tests - zip,dir,blacklist,etc.
ethangreen-dev Nov 27, 2025
f4d10ac
fix: copy path crash
WilsontheWolf Nov 27, 2025
b89fc02
fix: panic when mod without patches
WilsontheWolf Nov 27, 2025
b6d644e
fix: build failures caused by rebase
ethangreen-dev Jan 21, 2026
1b59eb0
fix: reintroduce patch_dir template string + zip path support
ethangreen-dev Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
449 changes: 434 additions & 15 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions crates/lovely-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ serde_ignored = "0.1.10"
itertools = "0.13.0"
crop = "0.4.2"
anyhow = "1.0.100"
zip = "6.0.0"

[dev-dependencies]
criterion = { version = "0.7", default-features = false }
tempfile = "3"

[[bench]]
name = "patches"
Expand Down
10 changes: 5 additions & 5 deletions crates/lovely-core/src/chunk_vec_cursor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ impl<'a> regex_cursor::Cursor for ChunkVecCursor<'a> {

fn advance(&mut self) -> bool {
if self.idx + 1 >= self.chunks.len() {
return false
return false;
}
self.offset += self.chunks[self.idx].len();
self.idx += 1;
Expand All @@ -29,7 +29,7 @@ impl<'a> regex_cursor::Cursor for ChunkVecCursor<'a> {

fn backtrack(&mut self) -> bool {
if self.idx == 0 {
return false
return false;
}
self.idx -= 1;
self.offset -= self.chunks[self.idx].len();
Expand All @@ -47,7 +47,7 @@ impl<'a> regex_cursor::Cursor for ChunkVecCursor<'a> {

impl<'a> IntoCursor for &'a crop::Rope {
type Cursor = ChunkVecCursor<'a>;

fn into_cursor(self) -> Self::Cursor {
ChunkVecCursor {
chunks: self.chunks().collect_vec(),
Expand All @@ -60,7 +60,7 @@ impl<'a> IntoCursor for &'a crop::Rope {

impl<'a> IntoCursor for crop::RopeSlice<'a> {
type Cursor = ChunkVecCursor<'a>;

fn into_cursor(self) -> Self::Cursor {
ChunkVecCursor {
chunks: self.chunks().collect_vec(),
Expand All @@ -69,4 +69,4 @@ impl<'a> IntoCursor for crop::RopeSlice<'a> {
offset: 0,
}
}
}
}
Loading
Loading