Skip to content

fix(tests/static): Fix all static tests for Osaka fork #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2025

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jul 31, 2025

🗒️ Description

Fixes all tests to either:

  • Use a lower gas limit while still preserving their full functionality.
  • Disabling tests for which the lower gas limit would break functionality in Osaka.

The methodology to this PR was to use the new fill gas-optimization feature in #1979 to ensure that the gas limit reductions do not break the functionality of the test.

The tests that could not have their gas limits reduced where disabled in Osaka by adding >=Cancun<Osaka in the network/expectations list.

Requires: #1977

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

marioevz added 3 commits July 31, 2025 17:23
fix(tests/static): stEIP1559

fix(tests/static): stMemoryStressTest

fix(tests/static): Optimize gas requirements for Osaka Pt. 2

fix(tests/static): Optimize gas requirements for Osaka Pt. 3

fix(tests/static): Optimize gas requirements for Osaka Pt. 4

fix(tests/static): Optimize gas requirements for Osaka Pt. 5

fix(tests/static): Optimize gas requirements for Osaka Pt. 6
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spencer-tb spencer-tb merged commit 66db99d into main Aug 5, 2025
16 checks passed
@spencer-tb spencer-tb deleted the fix-static-tests-fork-osaka branch August 5, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants