Skip to content

chore(consume): remove consume hive command #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ Users can select any of the artifacts depending on their testing needs for their
- 🔀 Refactor consume simulator architecture to use explicit pytest plugin structure with forward-looking architecture ([#1801](https://github.com/ethereum/execution-spec-tests/pull/1801)).
- 🔀 Add exponential retry logic to initial fcu within consume engine ([#1815](https://github.com/ethereum/execution-spec-tests/pull/1815)).
- ✨ Add `consume sync` command to test client synchronization capabilities by having one client sync from another via Engine API and P2P networking ([#2007](https://github.com/ethereum/execution-spec-tests/pull/2007)).
- 💥 Removed the `consume hive` command, this was a convenience command that ran `consume rlp` and `consume engine` in one pytest session; the individual commands should now be used instead ([#2008](https://github.com/ethereum/execution-spec-tests/pull/2008)).

#### `execute`

Expand Down
13 changes: 1 addition & 12 deletions src/cli/pytest_commands/consume.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,7 @@ def create_consume_command(
def get_command_logic_test_paths(command_name: str, is_hive: bool) -> List[Path]:
"""Determine the command paths based on the command name and hive flag."""
base_path = Path("pytest_plugins/consume")
if command_name == "hive":
commands = ["rlp", "engine"]
command_logic_test_paths = [
base_path / "simulators" / "simulator_logic" / f"test_via_{cmd}.py" for cmd in commands
]
elif command_name in ["engine", "rlp"]:
if command_name in ["engine", "rlp"]:
command_logic_test_paths = [
base_path / "simulators" / "simulator_logic" / f"test_via_{command_name}.py"
]
Expand Down Expand Up @@ -117,12 +112,6 @@ def sync() -> None:
pass


@consume_command(is_hive=True)
def hive() -> None:
"""Client consumes via all available hive methods (rlp, engine)."""
pass


@consume.command(
context_settings={"ignore_unknown_options": True},
)
Expand Down
1 change: 0 additions & 1 deletion src/pytest_plugins/help/tests/test_help.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ def test_local_arguments_present_in_fill_help(pytester, help_flag):
("direct", "--consume-help"),
("rlp", "--consume-help"),
("engine", "--consume-help"),
("hive", "--consume-help"),
],
)
def test_local_arguments_present_in_base_consume_help(pytester, help_flag, command):
Expand Down
Loading