📄 docs(tests): Update EIP-7928 test case document to include no-op and OOG#2116
📄 docs(tests): Update EIP-7928 test case document to include no-op and OOG#2116
Conversation
|
Delegated accounts (EIP-7702) are not covered, when CALL/DELEGATECALL/STATICCALL/CALLCODE is called for delegated account there are edge case where first account get loaded but we dont have gas for second load etc. There are two variants:
|
marioevz
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR!
I've added some comments to the document as I feel we should modify our approach here slightly. Thanks!
2104098 to
e7367f8
Compare
marioevz
left a comment
There was a problem hiding this comment.
Awesome test ideas!
I feel the distinction I mention in my comment is extremely important and we should at least mention it so we don't miss on implementing all of the different flavors of these scenarios.
ea7a1b6 to
bcaf230
Compare
|
Some other small OOG ideas
|
853435a to
5dc7c07
Compare
|
We are proceeding to merge this one because we want to lower the open PR count to zero for the weld. If you need to reopen a new PR to track new test cases we can do it on the execution-specs repo. |
5dc7c07 to
8daf38f
Compare
…d OOG (ethereum#2116) * ✨ feat: Missed noop, new oog test casses * 📄 docs(tests): OOG 7702 * 🧹 chore: Better grouping * fix: issues with lint on main --------- Co-authored-by: raxhvl <raxhvl@users.noreply.github.com> Co-authored-by: fselmo <fselmo2@gmail.com>
🗒️ Description
New OOG test cases proposed by @rakita have been added to the
test_cases.mdfor EIP-7928. The no-op test case, which was missed during the rebase of the framework changes, has been patched in.Related Reth PR: paradigmxyz/reth#17765 and bluealloy/revm#2903
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.