Skip to content

Conversation

gurukamath
Copy link
Contributor

@gurukamath gurukamath commented Aug 1, 2025

(closes #1352)

What was wrong?

Currently, every fork has its own tests folder. So does the EEST repository. In a post-weld world, this could get really messy. Hence, execution-specs need to have a simpler test folder structure to enable the EEST test folders to seamlessly move into the repository.

Related to Issue #1352

How was it fixed?

This PR performs the following changes

  1. Re-factors and moves all the fork specific tests (primarily the blockchain tests and the state tests) in the json_infra folder
  2. Make the test running less verbose and more maintainable.
  3. Removes the difficulty tests which were not running until now anyway in the CI
  4. Removes the fork specific rlp tests. There is enough rlp encoding and decoding happening in the json fixture tests that these tests are largely redundant.

Cute Animal Picture

Cute Animals - 1 of 1

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.26%. Comparing base (87a9e65) to head (90de63b).
⚠️ Report is 1 commits behind head on forks/osaka.

Additional details and impacted files
@@               Coverage Diff               @@
##           forks/osaka    #1360      +/-   ##
===============================================
+ Coverage        94.15%   94.26%   +0.10%     
===============================================
  Files              583      583              
  Lines            34666    34666              
  Branches          3070     3070              
===============================================
+ Hits             32641    32677      +36     
+ Misses            1492     1454      -38     
- Partials           533      535       +2     
Flag Coverage Δ
unittests 94.26% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gurukamath gurukamath changed the title move other tests to json_infra move current tests to json_infra: re-factor(weld) Aug 3, 2025
@gurukamath gurukamath changed the title move current tests to json_infra: re-factor(weld) re-factor(weld): move current tests to json_infra Aug 3, 2025
@SamWilsn
Copy link
Contributor

SamWilsn commented Aug 6, 2025

Removes the fork specific rlp tests. There is enough rlp encoding and decoding happening in the json fixture tests that these tests are largely redundant.

Is there anything we should move into ethereum-rlp?

@gurukamath
Copy link
Contributor Author

Is there anything we should move into ethereum-rlp?

Actually most of these tests use fork related types like Header, Transaction etc. And I don't think these contribute significantly to testing the spec. So, I'd still be in favor of just getting rid of them

@gurukamath gurukamath force-pushed the refactor-eels-tests branch from c0ee7ea to 3dad5f7 Compare August 12, 2025 12:05
@gurukamath
Copy link
Contributor Author

@SamWilsn Have updated the PR based on the feedback

@gurukamath gurukamath merged commit a7b8712 into ethereum:forks/osaka Aug 14, 2025
3 checks passed
@gurukamath gurukamath deleted the refactor-eels-tests branch August 28, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move json_infra tests into their own folder
4 participants