-
Notifications
You must be signed in to change notification settings - Fork 330
re-factor(weld): move current tests to json_infra #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-factor(weld): move current tests to json_infra #1360
Conversation
87ae33a
to
c0ee7ea
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1360 +/- ##
===============================================
+ Coverage 94.15% 94.26% +0.10%
===============================================
Files 583 583
Lines 34666 34666
Branches 3070 3070
===============================================
+ Hits 32641 32677 +36
+ Misses 1492 1454 -38
- Partials 533 535 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Is there anything we should move into |
Actually most of these tests use fork related types like |
c0ee7ea
to
3dad5f7
Compare
@SamWilsn Have updated the PR based on the feedback |
(closes #1352)
What was wrong?
Currently, every fork has its own tests folder. So does the EEST repository. In a post-weld world, this could get really messy. Hence,
execution-specs
need to have a simpler test folder structure to enable the EEST test folders to seamlessly move into the repository.Related to Issue #1352
How was it fixed?
This PR performs the following changes
json_infra
folderCute Animal Picture