ethclient/gethclient: use common.Hash to debug_traceTransaction #32404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Fibonacci747
commented
Aug 12, 2025
Fibonacci747
commented
- Unifies hash argument encoding: TraceTransaction now passes common.Hash directly, matching TraceBlock and other RPC calls.
- Leverages common.Hash JSON marshaling (0x‑prefixed hex via MarshalText); no functional change expected.
- Aligns with RPC handler signature (tracers.API.TraceBlockByHash(ctx, hash common.Hash, ...)) and existing ethclient usage (e.g., eth_getBlockByHash, eth_getTransactionByHash).
- Simplifies code by avoiding unnecessary Hex() conversion and improves consistency/readability.
…stency Unifies hash argument encoding: TraceTransaction now passes common.Hash directly, matching TraceBlock and other RPC calls. Leverages common.Hash JSON marshaling (0x‑prefixed hex via MarshalText); no functional change expected. Aligns with RPC handler signature (tracers.API.TraceBlockByHash(ctx, hash common.Hash, ...)) and existing ethclient usage (e.g., eth_getBlockByHash, eth_getTransactionByHash). Simplifies code by avoiding unnecessary Hex() conversion and improves consistency/readability.
rjl493456442
changed the title
rjl493456442
approved these changes
Aug 19, 2025
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 29, 2025
Merged
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Aug 31, 2025
gzliudan
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.