core/state: fix bug about getting stable LogsHash result. #33082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses non-deterministic log ordering by ensuring logs are returned in a stable, consistent order. Map iteration in Go is intentionally randomized, which can cause the Logs() method to return logs in different orders across multiple calls, potentially affecting hash calculations like LogsHash.
- Added sorting of logs by
TxIndexto ensure deterministic ordering - Imported the
sortpackage to support the sorting operation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
mask-pp
changed the title
rjl493456442
reviewed
Nov 4, 2025
rjl493456442
reviewed
Nov 4, 2025
Removed comment about sorting logs by TxIndex.
rjl493456442
approved these changes
Nov 4, 2025
wit765
added a commit
to wit765/XDPoSChain
that referenced
this pull request
Nov 12, 2025
19 tasks
wit765
added a commit
to wit765/XDPoSChain
that referenced
this pull request
Nov 12, 2025
wit765
added a commit
to wit765/XDPoSChain
that referenced
this pull request
Nov 12, 2025
AnilChinchawale
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Nov 14, 2025
atkinsonholly
pushed a commit
to atkinsonholly/ephemery-geth
that referenced
this pull request
Nov 24, 2025
…3082) Because the map iteration is unstable, we need to order logs by tx index and keep the same order with receipts and their logs, so we can still get the same `LogsHash` across runs. --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: rjl493456442 <[email protected]>
prestoalvarez
pushed a commit
to prestoalvarez/go-ethereum
that referenced
this pull request
Nov 27, 2025
…3082) Because the map iteration is unstable, we need to order logs by tx index and keep the same order with receipts and their logs, so we can still get the same `LogsHash` across runs. --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: rjl493456442 <[email protected]>
fjl
pushed a commit
to lightclient/go-ethereum
that referenced
this pull request
Nov 28, 2025
…3082) Because the map iteration is unstable, we need to order logs by tx index and keep the same order with receipts and their logs, so we can still get the same `LogsHash` across runs. --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: rjl493456442 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the map iteration is unstable, we need to order logs by tx index and keep the same order with receipts and their logs, so we can still get the same
LogsHashacross runs.