Skip to content

core/state: fix bug about getting stable LogsHash result. #33082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjl493456442 merged 5 commits into from
Nov 7, 2025
+4 −0
Merged

core/state: fix bug about getting stable LogsHash result. #33082

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e873140
get stable LogsHash result
mask-pp Nov 2, 2025
9b9c138
Update core/state/statedb.go
mask-pp Nov 2, 2025
26fbb40
Update core/state/statedb.go
mask-pp Nov 2, 2025
207f434
fix comments
mask-pp Nov 4, 2025
c694125
Remove comment on log sorting stability
rjl493456442 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/state/statedb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
"fmt"
"maps"
"slices"
"sort"
"sync"
"sync/atomic"
"time"
Expand Down Expand Up @@ -264,6 +265,10 @@ func (s *StateDB) Logs() []*types.Log {
for _, lgs := range s.logs {
logs = append(logs, lgs...)
}
// Due to the map iteration is not stable, we need to sort the logs by TxIndex, then the LogsHash result is stable.
sort.Slice(logs, func(i, j int) bool {
return logs[i].TxIndex < logs[j].TxIndex
})
return logs
}

Expand Down
Loading