Skip to content

Conversation

@cuiweixie
Copy link
Contributor

@cuiweixie cuiweixie commented Dec 1, 2025

geth --nodiscover=false
may result in ctx.IsSet(NoDiscoverFlag.Name) is true, but cfg. NoDiscovery should be false, not true.

@gballet
Copy link
Member

gballet commented Dec 1, 2025

Hi, thanks a lot for your contribution! 🙏
At the moment, the go-ethereum team is overloaded with pull requests and in order to ensure we can give high quality review and attention to critical changes, we are not accepting refactoring-only PRs or minor upgrades.

We really appreciate the effort and encourage you to keep contributing, but for now we need to focus our limited review bandwidth on feature work, bug fixes, and protocol changes.

Thanks for understanding!

@gballet gballet closed this Dec 1, 2025
@jwasinger
Copy link
Contributor

This is worth merging.

@jwasinger jwasinger reopened this Dec 1, 2025
@fjl fjl changed the title cmd/utils: flags should not be setted to true directly cmd/utils: fix handling of boolean flags when they are set to false Dec 2, 2025
@jwasinger jwasinger merged commit be94ea1 into ethereum:master Dec 2, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants