Skip to content

Christoph/review/1420 #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

cburgdorf
Copy link
Contributor

Temp PR to diagnose errors

@Bhargavasomu
Copy link
Contributor

Some installation problem with the RocksDB.

@cburgdorf cburgdorf force-pushed the christoph/review/1420 branch from 0c14e29 to a1952e8 Compare October 25, 2018 11:49
@cburgdorf
Copy link
Contributor Author

@Bhargavasomu yep, trying to figure out why...because I haven't had any problems after rebasing #1424 on top of latest master

@Bhargavasomu
Copy link
Contributor

@cburgdorf , #1181 failed for the same reasons, by looking at the details given by circleci

@cburgdorf
Copy link
Contributor Author

I installed rocks-db locally and I'm running into the same issue. Waiting for @pipermerriam to jump in but my initial reaction would be to revert 61a9a37 if we can't find a fix soon. That said, going to lunch now and will give it more thought / debugging afterwards.

@Bhargavasomu
Copy link
Contributor

Bhargavasomu commented Oct 25, 2018

@cburgdorf #1431 seems to make the necessary header files accessible. Could you please take a look at it? I have made a link to the header files, which I don't think was previously present. But it is taking a lot of time to run the test cases. Is this because I have cleared the cache somewhere? (Accidentally though)

@cburgdorf cburgdorf force-pushed the christoph/review/1420 branch from a1952e8 to 22f9ddc Compare October 25, 2018 13:54
@cburgdorf
Copy link
Contributor Author

@Bhargavasomu nice find. I rebased this on top of #1431 just to double check :)

@pipermerriam
Copy link
Member

I'm fine with us rolling back #1416 for now until we get #1426 in place or something similar which makes this more reliable.

@pipermerriam
Copy link
Member

you can bust the cache by incrementing the v1/v2 numbers in the cache strings in the ./circleci/config file. But given that this has happened more than once (already happened to me once while trying to get the PR green), I suspect it'll happen again.

@cburgdorf cburgdorf force-pushed the christoph/review/1420 branch from e0d8004 to c2ad10b Compare October 25, 2018 15:28
@cburgdorf cburgdorf force-pushed the christoph/review/1420 branch from 26d25cc to b43ffa8 Compare October 25, 2018 16:31
@cburgdorf cburgdorf force-pushed the christoph/review/1420 branch from b43ffa8 to 024dd70 Compare October 25, 2018 16:35
@cburgdorf cburgdorf closed this Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants