-
Notifications
You must be signed in to change notification settings - Fork 692
Christoph/review/1420 #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Christoph/review/1420 #1430
Conversation
Some installation problem with the |
0c14e29
to
a1952e8
Compare
@Bhargavasomu yep, trying to figure out why...because I haven't had any problems after rebasing #1424 on top of latest master |
@cburgdorf , #1181 failed for the same reasons, by looking at the details given by |
I installed rocks-db locally and I'm running into the same issue. Waiting for @pipermerriam to jump in but my initial reaction would be to revert 61a9a37 if we can't find a fix soon. That said, going to lunch now and will give it more thought / debugging afterwards. |
@cburgdorf #1431 seems to make the necessary header files accessible. Could you please take a look at it? I have made a link to the header files, which I don't think was previously present. But it is taking a lot of time to run the test cases. Is this because I have cleared the cache somewhere? (Accidentally though) |
a1952e8
to
22f9ddc
Compare
@Bhargavasomu nice find. I rebased this on top of #1431 just to double check :) |
22f9ddc
to
e0d8004
Compare
I'm fine with us rolling back #1416 for now until we get #1426 in place or something similar which makes this more reliable. |
you can bust the cache by incrementing the |
e0d8004
to
c2ad10b
Compare
26d25cc
to
b43ffa8
Compare
b43ffa8
to
024dd70
Compare
Temp PR to diagnose errors