This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Making RocksDB installation Global #1431
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bhargavasomu
force-pushed
the
fixing_rocksdb_installation
branch
from
92c39eb to
1f2ba60
Compare
Closed
|
I can't properly validate this yet. I tried to rebase #1430 on top to see if that would get CI green again but it still fails which I believe is due to a caching issue. Not sure how to resolve that yet though. In the meantime I'm trying to get Trinity to work with rocks-db on my local machine because I'm also running into the issue (or maybe not the same I dunno) there. |
|
Closing as we decided to roll back (#1432) RocksDB support until we smooth out the installation story. Thanks for helping debugging this though! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
RocksDB header files (
slice.h) were not accessible globallyHow was it fixed?
Creating a link to
~/rocksdb/includeat/usr/include, should solve the issue.Cute Animal Picture