fix(ci): make dependencies update bot commit under github-actions account instead of users #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
requested review from
carver,
morph-dev,
mrferris,
njgheorghita and
ogenev
ogenev
reviewed
Feb 17, 2025
.github/workflows/dependencies.yml
Outdated
| name: Update | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write |
Member
There was a problem hiding this comment.
Why do we need the both permissions set to write?
Member
Author
There was a problem hiding this comment.
I just removed the unneeded permissions as it appears to work without it KolbyML#6
I added it as apparently in certain conditions it can be required it looks like
https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#token
ogenev
approved these changes
Feb 17, 2025
oac1771
pushed a commit
to oac1771/trin
that referenced
this pull request
Feb 23, 2025
…ount instead of users (ethereum#1686)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Currently every time our CI dependencies bot runs it commits under a user account, instead of github actions bot.
This PR and commit isn't being made by a user, it is being made by github actions bot account, so we probably shouldn't be comitting it under a user's account
How was it fixed?
I tested this locally on my fork KolbyML#5
Now it commits the update dependencies commit under the bots account