Skip to content

fix(ci): make dependencies update bot commit under github-actions account instead of users #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2025
Merged

fix(ci): make dependencies update bot commit under github-actions account instead of users #1686

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db3310a
fix(ci): make dependencies update bot commit under github-actions acc…
KolbyML Feb 16, 2025
bf66952
fix: remove unneeded permissions
KolbyML Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ jobs:
update:
name: Update
runs-on: ubuntu-latest
permissions:
contents: write
Copy link
Member

@ogenev ogenev Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the both permissions set to write?

Copy link
Member Author

@KolbyML KolbyML Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed the unneeded permissions as it appears to work without it KolbyML#6

I added it as apparently in certain conditions it can be required it looks like

https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#token
image

pull-requests: write
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
Expand All @@ -57,6 +60,7 @@ jobs:
with:
add-paths: ./Cargo.lock
commit-message: ${{ steps.msg.outputs.commit_message }}
author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
title: ${{ env.TITLE }}
body: ${{ steps.msg.outputs.body }}
branch: ${{ env.BRANCH }}
Loading