fix(api): resolve panic when storage incentives disabled #5150
Conversation
pkg/api/router.go
Outdated
| func (s *Service) checkStorageIncentivesAvailability(handler http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if s.redistributionAgent == nil { | ||
| jsonhttp.NotImplemented(w, "Storage incentives are disabled. This endpoint is unavailable.") |
There was a problem hiding this comment.
well, it is implemented, it is more like a 404 Not Found or a 403 Forbidden. I would simply go with 404
There was a problem hiding this comment.
We have used this status code when Swap is disabled and Chequebook is disabled, which was done in this PR. But we can change it to 403 Forbidden, because route does exit, but it is disabled on server side. In that case we should change this for all 3 endpoints to have the same behaviour.
@janos, @nugaon any opion on this?
There was a problem hiding this comment.
403 is also fine from my side on all similar places
There was a problem hiding this comment.
tests still need to be adjusted: https://github.com/ethersphere/bee/actions/runs/16437874357/job/46453779979?pr=5150
Checklist
Description
Adds handler that checks if redistributionAgent is initialized.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Redistribution handler panics when called with storage incentives disabled #5143
Screenshots (if appropriate):