Skip to content

Conversation

@jpople
Copy link
Contributor

@jpople jpople commented Jan 16, 2026

Ticket ENG-2406

Description Of Changes

Fixes a regression in #7196 which caused messaging templates table to incorrectly display messaging template keys instead of human-readable labels.

Steps to Confirm

  1. View messaging templates table; verify labels are shown, not ID strings

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@jpople jpople requested a review from a team as a code owner January 16, 2026 05:40
@jpople jpople requested review from lucanovera and removed request for a team January 16, 2026 05:40
@vercel
Copy link
Contributor

vercel bot commented Jan 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 16, 2026 5:44am
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 16, 2026 5:44am

Review with Vercel Agent

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 16, 2026

Greptile Summary

Fixed a regression from PR #7196 where the messaging templates table was displaying enum keys (e.g., privacy_request_complete_access) instead of human-readable labels (e.g., "Access request completed").

Changes:

  • Updated the Message column render function to use CustomizableMessagingTemplatesLabelEnum mapping for proper label display
  • Modified Cypress test to verify human-readable labels appear and enum keys do not

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Straightforward bug fix that correctly maps enum keys to display labels. The change is well-tested with appropriate Cypress assertions and follows existing patterns in the codebase.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/pages/notifications/templates/index.tsx Fixed regression by mapping template type enum keys to human-readable labels
clients/admin-ui/cypress/e2e/messaging.cy.ts Updated test to verify human-readable labels are displayed instead of enum keys

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the bug and that this PR fixes the issue. Approved!

@jpople jpople added this pull request to the merge queue Jan 16, 2026
Merged via the queue into main with commit eb2fc33 Jan 16, 2026
46 of 47 checks passed
@jpople jpople deleted the jpople/eng-708/fix-template-table-regression branch January 16, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants