Skip to content

Enigmadark invariant suite #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Enigmadark invariant suite #9

wants to merge 19 commits into from

Conversation

vnmrtz
Copy link
Collaborator

@vnmrtz vnmrtz commented Jan 1, 2025

No description provided.

haythemsellami
haythemsellami reviewed Jan 10, 2025
View reviewed changes
test/enigma-dark-invariants/Setup.t.sol Outdated
Comment on lines 156 to 157
debtLimit0: 500e18, // TODO tweak these numbers
debtLimit1: 500e18,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a setup with different pools that have different/random debt limits?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be using a factory, it may make this setup easier to deploy once it get merged #7

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the comment below, I added maglev parameters randomisation, including debtLimits. Could you clarify what you mean by ‘different pools’?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just meant pools with different random params.

haythemsellami
haythemsellami reviewed Jan 10, 2025
View reviewed changes
test/enigma-dark-invariants/Setup.t.sol Outdated
Comment on lines 187 to 191
MaglevEulerSwap.EulerSwapParams({
priceX: 1e18,
priceY: 1e18,
concentrationX: 0.4e18,
concentrationY: 0.85e18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fuzz those inputs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm working on randomising maglev deployments and setup using a couple of tricks on echidna

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up and working, thanks for the idea: https://github.com/euler-xyz/euler-maglev/blob/af8d4a4928c206019ed588c6d525b777bfca76d6/test/enigma-dark-invariants/handlers/setup/MaglevSetupHandler.t.sol#L26-L81

hoytech added a commit that referenced this pull request Mar 12, 2025
@hoytech
Make factory check that vaults are created by EVK factory
79158fe 
spearbit #9
hoytech added a commit that referenced this pull request Mar 12, 2025
@hoytech
Make factory check that vaults are created by EVK factory
e3c7a40 
spearbit #9
@saucepoint saucepoint mentioned this pull request May 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haythemsellami haythemsellami haythemsellami left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnmrtz @haythemsellami