Assume one-time donation if no frequency selected#443
Merged
markulrich merged 1 commit intomainfrom Sep 25, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies donation frequency handling by defaulting to one-time donations when no frequency is selected. This change removes the need for complex frequency validation logic in the UI components.
- Default frequency to
DonationFrequency.OneTimewhen no frequency is provided - Simplify submit button disabled state logic by removing frequency-related validation
- Remove unused imports and variables related to frequency checking
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/donate-button-v4/src/helpers/constructDonateUrl.ts | Adds default one-time frequency assignment using logical OR assignment operator |
| packages/donate-button-v4/src/components/widget/components/PaymentProcess/DefaultFlow/index.tsx | Removes frequency validation logic and unused imports, simplifying submit button state |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.