Skip to content
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions config.json
Original file line number Diff line number Diff line change
Expand Up @@ -2720,6 +2720,14 @@
"practices": [],
"prerequisites": [],
"difficulty": 2
},
{
"slug": "error-handling",
"name": "Error Handling",
"uuid": "de1c75f2-2461-4347-b5ca-b3cfaafe4d79",
"practices": [],
"prerequisites": [],
"difficulty": 1
}
]
},
Expand Down
8 changes: 8 additions & 0 deletions exercises/practice/error-handling/.docs/instructions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Instructions

Implement various kinds of error handling and resource management.

An important point of programming is how to handle errors and close resources even if errors occur.

This exercise requires you to handle various errors.
Because error handling is rather programming language specific you'll have to refer to the tests for your track to see what's exactly required.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line probably needs to be removed, or at least changed because it's generic from the problem-spec repo

15 changes: 15 additions & 0 deletions exercises/practice/error-handling/.docs/introduction.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Error Handling

In this exercise, you will implement a function called `processString` that processes a given input string with proper error handling.

You will learn how to:

- Check input types and throw errors for invalid inputs.
- Throw errors for specific cases (e.g., empty strings).
- Return the uppercase version of the string if it is valid.

Your function should:

- Throw a `TypeError` if input is not a string.
- Throw a general `Error` if input is an empty string.
- Return the uppercase form of the string 'hello'.
5 changes: 5 additions & 0 deletions exercises/practice/error-handling/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
/node_modules
/bin/configlet
/bin/configlet.exe
/package-lock.json
/yarn.lock
17 changes: 17 additions & 0 deletions exercises/practice/error-handling/.meta/config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"authors": [
"A-O-Emmanuel"
],
"files": {
"solution": [
"error-handling.js"
],
"test": [
"error-handling.spec.js"
],
"example": [
".meta/proof.ci.js"
]
},
"blurb": "Implement various kinds of error handling and resource management."
}
9 changes: 9 additions & 0 deletions exercises/practice/error-handling/.meta/proof.ci.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
export const processString = (input) => {
if (typeof input !== 'string') {
throw new TypeError();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We almost always want a message in an error. We don't need to test the exact message, but throwing an empty error is non-idiomatic.

}
if (input === '') {
throw new Error();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We almost always want a message in an error. We don't need to test the exact message, but throwing an empty error is non-idiomatic.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll add that

}
return input.toUpperCase();
};
1 change: 1 addition & 0 deletions exercises/practice/error-handling/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
audit=false
21 changes: 21 additions & 0 deletions exercises/practice/error-handling/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
MIT License

Copyright (c) 2021 Exercism

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
4 changes: 4 additions & 0 deletions exercises/practice/error-handling/babel.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module.exports = {
presets: [['@exercism/babel-preset-javascript', { corejs: '3.40' }]],
plugins: [],
};
6 changes: 6 additions & 0 deletions exercises/practice/error-handling/error-handling.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export const processString = (input) => {
//TODO: implement this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all other stubs we throw new Error('...') (I don't recall the exact error message). We probably want to use that!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

//should throw TypeError if input is not a string
//should throw a general Error if input is an empty string
//should return the uppercase version of the string 'hello'
};
16 changes: 16 additions & 0 deletions exercises/practice/error-handling/error-handling.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { describe, expect, test, xtest } from '@jest/globals';
import { processString } from './error-handling';

describe('Error Handling', () => {
test('throws TypeError if input is not a string', () => {
expect(() => processString(42)).toThrow(TypeError);
});

xtest('throws Error message if string is empty', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk if i'm vibing with this test specifically, maybe we need to add some handling for the empty string case, instead of throwing error.

In any case, more tests are needed, like for example do we want the tests to pass with any generic Error type or do we want to allow only certain types?

expect(() => processString('')).toThrow(Error);
});

xtest('returns uppercase string if input is valid', () => {
expect(processString('hello')).toBe('HELLO');
});
});
45 changes: 45 additions & 0 deletions exercises/practice/error-handling/eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
// @ts-check

import config from '@exercism/eslint-config-javascript';
import maintainersConfig from '@exercism/eslint-config-javascript/maintainers.mjs';

import globals from 'globals';

export default [
...config,
...maintainersConfig,
{
files: maintainersConfig[1].files,
rules: {
'jest/expect-expect': ['warn', { assertFunctionNames: ['expect*'] }],
},
},
{
files: ['scripts/**/*.mjs'],
languageOptions: {
globals: {
...globals.node,
},
},
},
// <<inject-rules-here>>
{
ignores: [
// # Protected or generated
'/.appends/**/*',
'/.github/**/*',
'/.vscode/**/*',

// # Binaries
'/bin/*',

// # Configuration
'/config',
'/babel.config.js',

// # Typings
'/exercises/**/global.d.ts',
'/exercises/**/env.d.ts',
],
},
];
22 changes: 22 additions & 0 deletions exercises/practice/error-handling/jest.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
module.exports = {
verbose: true,
projects: ['<rootDir>'],
testMatch: [
'**/__tests__/**/*.[jt]s?(x)',
'**/test/**/*.[jt]s?(x)',
'**/?(*.)+(spec|test).[jt]s?(x)',
],
testPathIgnorePatterns: [
'/(?:production_)?node_modules/',
'.d.ts$',
'<rootDir>/test/fixtures',
'<rootDir>/test/helpers',
'__mocks__',
],
transform: {
'^.+\\.[jt]sx?$': 'babel-jest',
},
moduleNameMapper: {
'^(\\.\\/.+)\\.js$': '$1',
},
};
38 changes: 38 additions & 0 deletions exercises/practice/error-handling/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
"name": "@exercism/javascript-practice-error-handling",
"description": "Exercism practice exercise on error-handling",
"author": "Katrina Owen",
"contributors": [
"Derk-Jan Karrenbeld <[email protected]> (https://derk-jan.com)",
"Tejas Bubane (https://tejasbubane.github.io/)"
],
"private": true,
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/exercism/javascript",
"directory": "exercises/practice/error-handling"
},
"devDependencies": {
"@exercism/babel-preset-javascript": "^0.5.1",
"@exercism/eslint-config-javascript": "^0.8.1",
"@jest/globals": "^29.7.0",
"@types/node": "^22.15.29",
"@types/shelljs": "^0.8.17",
"babel-jest": "^29.7.0",
"core-js": "~3.42.0",
"diff": "^8.0.2",
"eslint": "^9.28.0",
"expect": "^29.7.0",
"globals": "^16.2.0",
"jest": "^29.7.0"
},
"dependencies": {},
"scripts": {
"lint": "corepack pnpm eslint .",
"test": "corepack pnpm jest",
"watch": "corepack pnpm jest --watch",
"format": "corepack pnpm prettier -w ."
},
"packageManager": "[email protected]"
}