Replacing bash script with Node.js wrapper for expf command#87
Merged
wesleytodd merged 5 commits intomainfrom Jan 14, 2026
Merged
Replacing bash script with Node.js wrapper for expf command#87wesleytodd merged 5 commits intomainfrom
wesleytodd merged 5 commits intomainfrom
Conversation
…or being platform agnostic
wesleytodd
reviewed
Jan 7, 2026
Member
Author
|
Requested changes made and tested, just waits to quick review and merge from Wes. |
wesleytodd
approved these changes
Jan 14, 2026
Member
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
Tested locally and just needed to update the permissions to be executable. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basicly, solves
The system cannot find the path specified.in Windows when calling expf with saving Symlink support.Tested in Windows but not in Unix, I guess you can help me on that @wesleytodd .
This pull request updates how JSON configuration files are dynamically imported in both the CLI and local runner packages, ensuring compatibility with Node.js ESM module resolution. It also changes the CLI entry point script. The most important changes are:
Dynamic JSON Import Improvements:
packages/cli/load.mjsandpackages/runner-local/setup.mjs, dynamic imports of JSON files now usepathToFileURLto convert file paths to file URLs before importing, which is required for ESM module compatibility in Node.js.CLI Entry Point Update:
packages/cli/package.jsonis changed frombin/expf.sh(a shell script) tobin/expf-wrapper.mjs(an ES module), aligning the CLI with modern Node.js practices.