Skip to content

Replacing bash script with Node.js wrapper for expf command #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesleytodd merged 5 commits into from
Jan 14, 2026
Merged

Replacing bash script with Node.js wrapper for expf command #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e977ea
refactor: replace bash script with Node.js wrapper for expf command f…
GroophyLifefor Dec 31, 2025
1a19168
fix: add newline at end of expf-wrapper.mjs for POSIX compliance
GroophyLifefor Dec 31, 2025
8ace62a
fix: simplify config import in load.mjs
GroophyLifefor Jan 7, 2026
3b747cd
refactor: remove expf-wrapper and update bin entry to point directly …
GroophyLifefor Jan 9, 2026
eeb0b5c
fix: new bin permissions
wesleytodd Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/cli/bin/expf.mjs
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#!/usr/bin/env node
import { parseArgs } from 'node:util';
import { argv } from 'node:process';

Expand Down
10 changes: 0 additions & 10 deletions packages/cli/bin/expf.sh
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion packages/cli/load.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ export default function main (_opts = {}) {

let conf = {};
try {
conf = (await import(join(cwd, _opts.config || 'expf.config.json'), {
const configPath = join(cwd, _opts.config || 'expf.config.json');
conf = (await import(configPath, {
with: {
type: 'json'
}
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"lint:fix": "semistandard --fix"
},
"bin": {
"expf": "./bin/expf.sh"
"expf": "./bin/expf.mjs"
},
"keywords": [],
"author": "",
Expand Down
4 changes: 3 additions & 1 deletion packages/runner-local/setup.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
constants as fsConstants
} from 'node:fs/promises';
import { dirname, join } from 'node:path';
import { pathToFileURL } from 'node:url';
import { promisify } from 'node:util';
import { execFile } from 'node:child_process';

Expand Down Expand Up @@ -50,7 +51,8 @@ export async function setup (cwd, opts = {}) {
const { pkgPath, pkgBakPath } = await restore(cwd);

// Read in package.json contets
const pkg = (await import(pkgPath, {
const pkgUrl = pathToFileURL(pkgPath).href;
const pkg = (await import(pkgUrl, {
with: {
type: 'json'
}
Expand Down
Loading