fix: checks if a default toolchains has been set#416
Merged
Ilia-Kosenkov merged 16 commits intoextendr:mainfrom Apr 1, 2025
albersonmiranda:issue-326
Merged
fix: checks if a default toolchains has been set#416Ilia-Kosenkov merged 16 commits intoextendr:mainfrom albersonmiranda:issue-326
Ilia-Kosenkov merged 16 commits intoextendr:mainfrom
albersonmiranda:issue-326
Conversation
Contributor
Author
|
@Ilia-Kosenkov Is something like this what you had in mind? |
Member
|
Yup |
JosiahParry
reviewed
Feb 25, 2025
JosiahParry
approved these changes
Feb 25, 2025
auto-merge was automatically disabled
February 25, 2025 21:33
Head branch was pushed to by a user without write access
Member
|
Hm, try rebasing onto main. The CI went through there |
Contributor
Author
@Ilia-Kosenkov All clear! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
This was referenced May 26, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #326
I'm opening as draft because I'm not sure if this is exaclty what is expected as solution. If it's OK, I'll add a test.
Steps to reproduce:
rustup default none.rustup shownow returnsrust_sitrep(), which should return