Skip to content

fix: checks if a default toolchains has been set#416

Merged
Ilia-Kosenkov merged 16 commits intoextendr:mainfrom
albersonmiranda:issue-326
Apr 1, 2025
Merged

fix: checks if a default toolchains has been set#416
Ilia-Kosenkov merged 16 commits intoextendr:mainfrom
albersonmiranda:issue-326

Conversation

@albersonmiranda
Copy link
Contributor

@albersonmiranda albersonmiranda commented Feb 20, 2025

Closes #326

I'm opening as draft because I'm not sure if this is exaclty what is expected as solution. If it's OK, I'll add a test.

Steps to reproduce:

  1. Unset default toolchain with rustup default none. rustup show now returns
installed toolchains
--------------------

error: no default toolchain configured
  1. Run rust_sitrep(), which should return
r$> rust_sitrep()
Rust infrastructure sitrep:
✔ "rustup": 1.27.1 (2024-04-24)
✔ "cargo": 1.84.0
ℹ host: aarch64-apple-darwin
ℹ toolchains: stable-aarch64-apple-darwin, 1.59.0-aarch64-apple-darwin, 1.60.0-aarch64-apple-darwin, 1.61.0-aarch64-apple-darwin, 1.63.0-aarch64-apple-darwin, and 1.70.0-aarch64-apple-darwin
! One of these toolchains should be default: stable-aarch64-apple-darwin, 1.59.0-aarch64-apple-darwin, 1.60.0-aarch64-apple-darwin, 1.61.0-aarch64-apple-darwin, 1.63.0-aarch64-apple-darwin, and 1.70.0-aarch64-apple-darwin
ℹ Run e.g. `rustup default stable-aarch64-apple-darwin`

@albersonmiranda albersonmiranda marked this pull request as ready for review February 25, 2025 00:14
@albersonmiranda
Copy link
Contributor Author

@Ilia-Kosenkov Is something like this what you had in mind?

@Ilia-Kosenkov
Copy link
Member

Yup

@JosiahParry JosiahParry enabled auto-merge (squash) February 25, 2025 16:21
auto-merge was automatically disabled February 25, 2025 21:33

Head branch was pushed to by a user without write access

@Ilia-Kosenkov
Copy link
Member

Hm, try rebasing onto main. The CI went through there

@albersonmiranda
Copy link
Contributor Author

albersonmiranda commented Apr 1, 2025

Hm, try rebasing onto main. The CI went through there

@Ilia-Kosenkov All clear!

@Ilia-Kosenkov Ilia-Kosenkov merged commit ebc97bd into extendr:main Apr 1, 2025
19 checks passed
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.20%. Comparing base (3221edc) to head (95049b8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/utils.R 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
R/rust_sitrep.R 97.43% <100.00%> (+0.13%) ⬆️
R/utils.R 96.00% <75.00%> (-4.00%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rust_sitrep() seems to fail to instruct the user if target is not gnu and matches toolchain arch on Windows

3 participants