fix: checks if a default toolchains has been set

.lintr

@@ -6,4 +6,4 @@ linters: linters_with_defaults(
 encoding: "UTF-8"
 exclusions: list(
       "R/import-standalone-obj-type.R"
-    )
+    )

NEWS.md

@@ -24,6 +24,7 @@
 * Added `use_msrv()` to aid in specifying the minimum supported rust version (MSRV) for an R package
 * Added `read_cargo_metadata()` to retrieve Cargo metadata for packages and
   workspaces. (#389)
+* `rustup_sitrep()` now checks if a default toolchain has been set. <https://github.com/extendr/rextendr/pull/416>
 
 # rextend 0.3.1
 

R/rust_sitrep.R

@@ -115,9 +115,15 @@
   # ----------------
   #
   # stable-x86_64-pc-windows-msvc (default)
-  host <- try_exec_cmd("rustup", "show") %>%
-    stringi::stri_sub(from = 15L) %>%
-    vctrs::vec_slice(1L)
+  host <- if (get_os() == "osx" && is.na(try_exec_cmd("rustup", "show"))) {
+    output <- try_exec_cmd("rustc", c("--version", "--verbose"))
+    host_index <- grep("host:", output)
+    gsub("host: ", "", output[host_index])
+  } else {
+    try_exec_cmd("rustup", "show") %>%
+      stringi::stri_sub(from = 15L) %>%
+      vctrs::vec_slice(1L)
+  }
 
   # > rustup toolchain list
   # stable-x86_64-pc-windows-msvc
@@ -177,7 +183,7 @@
   } else {
     toolchains[default_toolchain_index] <- cli::col_red(toolchains[default_toolchain_index])
     candidates <- stringi::stri_detect_fixed(toolchains, host)
-    if (any(candidates)) {
+    if (!all(is.na(candidates)) && any(candidates)) {
       candidate_toolchains <- toolchains[candidates]
       toolchains[candidates] <- cli::col_yellow(toolchains[candidates])
     } else {

R/utils.R

@@ -77,3 +77,19 @@
   }
   data
 }
+
+get_os <- function() {
+  sysinf <- Sys.info()
+  if (!is.null(sysinf)) {
+    os <- sysinf["sysname"]
+    if (os == "Darwin")
+      os <- "osx"
+  } else { ## mystery machine
+    os <- .Platform$OS.type
+    if (grepl("^darwin", R.version$os))
+      os <- "osx"
+    if (grepl("linux-gnu", R.version$os))
+      os <- "linux"
+  }
+  tolower(os)
+}

tests/testthat/_snaps/rust-sitrep.md

@@ -104,3 +104,16 @@
       ! Target required-target is required on this host machine
       i Run `rustup target add required-target` to install it
 
+# Detects host when default toolchain is not set (MacOS)
+
+    Code
+      rust_sitrep()
+    Message
+      Rust infrastructure sitrep:
+      v "rustup": 1.0.0 (0000000 0000-00-00)
+      v "cargo": 1.0.0 (0000000 0000-00-00)
+      i host: aarch64-apple-darwin
+      i toolchain: stable-aarch64-apple-darwin
+      ! This toolchain should be default: stable-aarch64-apple-darwin
+      i Run e.g. `rustup default stable-aarch64-apple-darwin`
+

tests/testthat/test-rust-sitrep.R

@@ -129,3 +129,27 @@ test_that("Required target is not available", {
   })
   expect_snapshot(rust_sitrep())
 })
+
+test_that("Detects host when default toolchain is not set (MacOS)", {
+  skip_if_not(get_os() == "osx")
+
+  local_mocked_bindings(try_exec_cmd = function(cmd, args) {
+    if (cmd == "cargo") {
+      "cargo 1.0.0 (0000000 0000-00-00)"
+    } else if (cmd == "rustup" & all(args %in% "--version")) {
+      "rustup 1.0.0 (0000000 0000-00-00)"
+    } else if (cmd == "rustc") {
+      "host: aarch64-apple-darwin"
+    } else if (all(args %in% "--version")) {
+      "rustup 1.0.0 (0000000 0000-00-00)"
+      NA_character_
+    } else if (all(args %in% c("toolchain", "list"))) {
+      "stable-aarch64-apple-darwin"
+    } else if (all(args %in% c("target", "list", "--installed"))) {
+      NA_character_
+    } else {
+      NA_character_
+    }
+  })
+  expect_snapshot(rust_sitrep())
+})

tests/testthat/test-utils.R

@@ -21,6 +21,11 @@ test_that("`try_exec_cmd()` returns stdout when command is available", {
   expect_equal(try_exec_cmd("echo", echo), echo)
 })
 
+test_that("`get_os()` returns a non-empty string", {
+  os <- get_os()
+  expect_true(is.character(os))
+  expect_true(nzchar(os))
+})
 
 test_that("`replace_na()` respects type", {
   x <- 1:5