EZP-31248: Fixed handling non-printable characters for Search

[hgiesenow]

Question	Answer
JIRA issue	EZP-31248
Bug/Improvement	yes
New feature	no
Target version	7.x
BC breaks	no
Tests pass	?
Doc needed	no

Replaces all special chracaters to avoid issues with SolR

TODO:

• Implement feature / fix a bug.
• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[andrerom]

@kmadejski is this overlapping with the PR you proposed perhaps?
If it makes sense to skip these things in kernel, I'm all for it as it makes sure search engines indexes the same.

ref: ezsystems/ezplatform-solr-search-engine#159

[kmadejski]

@hgiesenow thanks for your contribution!

@andrerom yes, it seems to cover also what I've tried to achieve in my PR. This is also probably what @gggeek had in mind in ezsystems/ezplatform-solr-search-engine#159 (comment).

@hgiesenow could you please double-check whether it for sure covers what has been described in this ticket: https://jira.ez.no/browse/EZP-30759?

[gggeek]

Maybe :-) I don't remember the details.

Otoh I think that some of the chars that are trimmed-away at the moment (both before and with this PR) should not be replaced with no-char but with a space instead.

Esp. tab, vertical-tab, form-feed could conceivably be used to separate two words. If we strip them out, we'd be joining those words together... possibly chars 1C-1E as well

[mateuszbieniek]

Hi @hgiesenow, do you need any help with this PR? 🙂

[mateuszbieniek]

Hi @kmadejski, @gggeek - I pushed a commit that handles tabs, horizontal tabs and form feed, so they are replaced with space.

Can you please give your review (for some reason I can't add you to reviewers)?

[gggeek]

better :-)

[andrerom]

+1, but should go to 6.13 and up on merge

[adamwojs]

+1 but I'm missing tests 😉

[mateuszbieniek]

@adamwojs had some problems with those, but should be ok now 😉

[tomaszszopinski]

QA approved on eZ Platform EE 2.5 with diff.

[alongosz]

Merged for eZ Platform v2.5.x via e4e7942 and for eZ Platform v3.0 via ezsystems/ezplatform-kernel@9e3ef6e.

Thank you @hgiesenow and @mateuszbieniek 🎉