Remove object link if user removes a related object in the objectrelationlist datatype attribute#1277
Open
pkamps wants to merge 1 commit intoezsystems:masterfrom
Open
Conversation
…tionlist datatype attribute
This was referenced Jan 20, 2017
Contributor
|
Nitpick, but why not keep the variable names the same as they where ? It would make it easier to 'get' what has changed and what not |
Contributor
Author
|
That's how it's fixed in the enterprise version. The code style is also not consistent... but there is probably a benefit to stay as close as possible to the enterprise code version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patch comes from the ez publish enterprise version. It fixes a bug in the objectrelationlist attribute: when removing an object relation in the attribute it was not removing it from the object relation DB table. This patch fixes the issue.
This patch replaces:
#1271
#1271 also contains steps how to test the fix.