feat(android): update service permissions #61
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| <uses-permission android:name="android.permission.FOREGROUND_SERVICE_DATA_SYNC" /> | ||
| <uses-permission android:name="android.permission.FOREGROUND_SERVICE_CONNECTED_DEVICE" /> | ||
| <service android:name="com.wearconnectivity.WearConnectivityTask" | ||
| android:permission="android.permission.BIND_JOB_SERVICE" | ||
| android:exported="true" /> | ||
| <intent-filter> | ||
| <action android:name="com.facebook.react.HeadlessJsTaskService" /> | ||
| </intent-filter> | ||
| android:permission="android.permission.FOREGROUND_SERVICE_CONNECTED_DEVICE" | ||
| android:exported="false" |
There was a problem hiding this comment.
[P0] Declare connectedDevice FGS type without raising compile SDK
The service now declares android:foregroundServiceType="dataSync|connectedDevice" and requests android.permission.FOREGROUND_SERVICE_CONNECTED_DEVICE. However the module still compiles with SDK 31 (see WearConnectivity_compileSdkVersion=31). API 31 does not define the connectedDevice foreground-service enum or the new permission, so ./gradlew :android:assemble will fail with an unknown flag during manifest processing. Either remove the Android 14-only values or bump the library’s compile/target SDKs so the build system knows about these new FGS types.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
yarn lint(fails: ESLint couldn't find the plugin "eslint-plugin-ft-flow"; installation attempt failed due to network restrictions)yarn typecheckyarn test(fails: Cannot find module '@react-native/babel-preset'; installation attempt failed due to network restrictions)https://chatgpt.com/codex/tasks/task_e_68b702ef4f748320a918e27ad55fc3b8