Skip to content

feat(android): update service permissions #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(android): update service permissions #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,14 @@
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.WAKE_LOCK"/>
<uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_DATA_SYNC" />
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_CONNECTED_DEVICE" />
<service android:name="com.wearconnectivity.WearConnectivityTask"
android:permission="android.permission.BIND_JOB_SERVICE"
android:exported="true" />
<intent-filter>
<action android:name="com.facebook.react.HeadlessJsTaskService" />
</intent-filter>
android:permission="android.permission.FOREGROUND_SERVICE_CONNECTED_DEVICE"
android:exported="false"
Comment on lines +6 to +10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P0] Declare connectedDevice FGS type without raising compile SDK

The service now declares android:foregroundServiceType="dataSync|connectedDevice" and requests android.permission.FOREGROUND_SERVICE_CONNECTED_DEVICE. However the module still compiles with SDK 31 (see WearConnectivity_compileSdkVersion=31). API 31 does not define the connectedDevice foreground-service enum or the new permission, so ./gradlew :android:assemble will fail with an unknown flag during manifest processing. Either remove the Android 14-only values or bump the library’s compile/target SDKs so the build system knows about these new FGS types.

Useful? React with 👍 / 👎.

android:foregroundServiceType="dataSync|connectedDevice">
<intent-filter>
<action android:name="com.facebook.react.HeadlessJsTaskService" />
</intent-filter>
</service>
</manifest>