fix Inlay hint insertion should consider imports/use qualified paths to auto import correctly #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinto0
requested changes
Nov 18, 2025
Contributor
kinto0
left a comment
kinto0
left a comment
There was a problem hiding this comment.
awesome work! a few suggestions + it looks like there are some merge conflicts. it might also be worth coordinating with @jvansch1 over discord to make sure you're not stepping on each other's toes since he's editing the same file
| result: Some(serde_json::json!([ | ||
| { | ||
| "label":" -> tuple[Literal[1], Literal[2]]", | ||
| "label":" -> tuple[typing.Literal[1], typing.Literal[2]]", |
Contributor
There was a problem hiding this comment.
cc @jvansch1 as you are also currently making changes to this
kinto0
requested changes
Nov 18, 2025
Contributor
kinto0
left a comment
kinto0
left a comment
There was a problem hiding this comment.
looks like the insertion text no longer matches the type
| "label":" -> tuple[Literal[1], Literal[2]]", | ||
| "position":{"character":21,"line":6}, | ||
| "textEdits":[{ | ||
| "newText":" -> tuple[Literal[1], Literal[2]]", |
Contributor
There was a problem hiding this comment.
Suggested change
| "newText":" -> tuple[Literal[1], Literal[2]]", | |
| "newText":" -> tuple[typing.Literal[1], typing.Literal[2]]", |
if we import typing, we need to qualify these types with it
Contributor
There was a problem hiding this comment.
I think this is still an issue
kinto0
requested changes
Nov 21, 2025
| "label":" -> tuple[Literal[1], Literal[2]]", | ||
| "position":{"character":21,"line":6}, | ||
| "textEdits":[{ | ||
| "newText":" -> tuple[Literal[1], Literal[2]]", |
Contributor
There was a problem hiding this comment.
I think this is still an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix part of #317
Type pretty-printing now tracks every module name it emits, so we can tell the client which imports a hint depends on; TypeDisplayContext stores the module set in a RefCell, exposes it via referenced_modules, and records each module.name combination as it formats the text
The LSP transaction layer wraps each hint in a new InlayHintWithEdits struct, renders annotations with fully qualified names, applies any local aliases (e.g., import typing as t), and bundles the necessary import edits by consulting the ImportTracker. This ensures that accepting a type hint also inserts import typing when the module hasn’t been brought into scope.
Downstream consumers now understand the richer hint payload: the server translates InlayHintWithEdits into multiple textEdits, the playground/WASM bindings expose the new label format, and the inlay-hint regression tests cover both standard and notebook scenarios to verify the extra import edits.