Skip to content

Conversation

zukofett
Copy link

@zukofett zukofett commented Jun 2, 2024

No description provided.

@facebook-github-bot
Copy link

Hi @zukofett!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Jun 2, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 2b56e20
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/665c1ec22ab98500080b578d
😎 Deploy Preview https://deploy-preview-4134--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Abbondanzo
Copy link
Contributor

Happy to merge this once CLA is complete!

| bool | `false` when `vertical={true}`<hr/>`true` otherwise |
| Type | Default |
| ---- | ----------------------------------------------------- |
| bool | `false` when `horizontal={true}`<hr/>`true` otherwise |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no vertical prop, and the conditional logic for defaults checks horizontal

@Simek
Copy link
Collaborator

Simek commented Aug 19, 2025

Hey @zukofett, thanks for the contribution! 👍

Since the PR was not updated for a while, closing in favour of:

@Simek Simek closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants