Skip to content

fix scrollview docs #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix scrollview docs #4134

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee9c6a2
fix scrollview docs
idan-baker Jun 2, 2024
d8bb85d
fix lint error
idan-baker Jun 2, 2024
2b56e20
Merge branch 'facebook:main' into main
zukofett Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/scrollview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@ When true, the scroll view bounces horizontally when it reaches the end even if

When true, the scroll view bounces vertically when it reaches the end even if the content is smaller than the scroll view itself.

| Type | Default |
| ---- | --------------------------------------------------- |
| bool | `false` when `vertical={true}`<hr/>`true` otherwise |
| Type | Default |
| ---- | ----------------------------------------------------- |
| bool | `false` when `horizontal={true}`<hr/>`true` otherwise |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no vertical prop, and the conditional logic for defaults checks horizontal


---

Expand Down