Skip to content

[iOS] Fix outputs when iOS artifacts generator is run from Xcode script phase #54066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+8 −4
Open

[iOS] Fix outputs when iOS artifacts generator is run from Xcode script phase #54066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b562c3
Use RCT_SCRIPT_OUTPUT_DIR env var to find autolinking.json output too
kitten Oct 6, 2025
b464256
Use real RCT_SCRIPT_OUTPUT_DIR for generate-codegen-artifacts in scri…
kitten Oct 6, 2025
c7af004
Add comments and separate pods/xcode autolinking.json loading
kitten Oct 6, 2025
449258e
Revert structural changes in react_native_pods_utils/script_phases.sh
kitten Oct 6, 2025
d5955f2
Move RCT_SCRIPT_OUTPUT_DIR switching to `generate-artifacts-executor/…
kitten Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-native/scripts/codegen/generate-artifacts-executor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,14 @@ function execute(

const reactNativeConfig = readReactNativeConfig(
projectRoot,
baseOutputPath,
// NOTE: Used to load `build/generated/autolinking/autolinking.json` generated by `scripts/cocoapods/autolinking.rb`
// If we have RCT_SCRIPT_OUTPUT_DIR (set in `react_native_pods_utils/script_phases.sh`, it takes precedence, otherwise
// we search for the `autolinking.json` output in the `baseOutputPath`
process.env.RCT_SCRIPT_OUTPUT_DIR != null && process.env.RCT_SCRIPT_OUTPUT_DIR.length > 0
? process.env.RCT_SCRIPT_OUTPUT_DIR
: baseOutputPath,
);

const codegenEnabledLibraries = findCodegenEnabledLibraries(
pkgJson,
projectRoot,
Expand Down
4 changes: 1 addition & 3 deletions packages/react-native/scripts/react_native_pods_utils/script_phases.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ generateCodegenArtifactsFromSchema () {
generateArtifacts () {
describe "Generating codegen artifacts"
pushd "$RCT_SCRIPT_RN_DIR" >/dev/null || exit 1
"$NODE_BINARY" "scripts/generate-codegen-artifacts.js" --path "$RCT_SCRIPT_APP_PATH" --outputPath "$TEMP_OUTPUT_DIR" --targetPlatform "ios"
"$NODE_BINARY" "scripts/generate-codegen-artifacts.js" --path "$RCT_SCRIPT_APP_PATH" --outputPath "$RCT_SCRIPT_OUTPUT_DIR" --targetPlatform "ios"
popd >/dev/null || exit 1
}

Expand All @@ -110,11 +110,9 @@ moveOutputs () {
}

withCodegenDiscovery () {
setup_dirs
find_node
find_codegen
generateArtifacts
moveOutputs
}

noCodegenDiscovery () {
Expand Down
Loading